Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Component: Terminal #15061

Closed
anthonyPierronAT opened this issue Mar 15, 2024 · 1 comment
Closed

Component: Terminal #15061

anthonyPierronAT opened this issue Mar 15, 2024 · 1 comment
Labels
Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible

Comments

@anthonyPierronAT
Copy link

Describe the bug

When using the terminal component, I get an injection error because of the TerminalService. This service is not singleton and it is never provided and only used in the constructor of the component.
The below screenshot is from your Stackblitz example of Terminal from your site which is in version 17.10.0.
image

Environment

MacOS

Reproducer

No response

Angular version

17.2.4

PrimeNG version

17.9.0

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

20.11.1

Browser(s)

Chrome 122.0.6261.129

Steps to reproduce the behavior

Open the demo of your Terminal component

Expected behavior

The terminal component not causing an injection error with the TerminalService.

@anthonyPierronAT anthonyPierronAT added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Mar 15, 2024
@mehmetcetin01140
Copy link
Contributor

Hi, this issue has been fixed in the latest version of PrimeNg (17.17.0).

Terminal demo (v17.17.0) = https://stackblitz.com/edit/prdev8?file=package.json

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible
Projects
None yet
Development

No branches or pull requests

2 participants