Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Component: Calendar - Update type for minDate and maxDate #15038

Closed
avytak opened this issue Mar 13, 2024 · 4 comments
Closed

Component: Calendar - Update type for minDate and maxDate #15038

avytak opened this issue Mar 13, 2024 · 4 comments
Labels
Resolution: Stale Issue or pull request is inactivity and unfortunately it will be *closed* if there is no response Type: Bug Issue contains a bug related to a specific component. Something about the component is not working

Comments

@avytak
Copy link

avytak commented Mar 13, 2024

Describe the bug

image
According to the documentation, the default value for the minDate and maxDate is Null
However, the setters for them accept only the Date format.
Is it possible to update the setters to accept Nullable?
I have a situation when in some cases I don't need to have the minDate in my calendar.
A possible workaround is to use unknown

<p-calendar						
dataType="string"
[minDate]="minDate"
[showIcon]="true"></p-calendar>

this.minDate= null as unknown as Date

,

Environment

Windows 10

Reproducer

No response

Angular version

16.2.8

PrimeNG version

16.5.1

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

18.19.1

Browser(s)

Chrome

Steps to reproduce the behavior

No response

Expected behavior

I will be able just to assign null to the variable, without using unknown.

@avytak avytak added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Mar 13, 2024
@mehmetcetin01140 mehmetcetin01140 added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Mar 18, 2024
@dobanisola-scottlogic
Copy link
Contributor

This issue can be closed as it has been fixed in this here.

@ThoSap
Copy link
Contributor

ThoSap commented Apr 29, 2024

No @dobanisola-scottlogic it was fixed here: #14754
See discussion https://github.com/orgs/primefaces/discussions/1136

@cetincakiroglu this issue can be closed.

Copy link

This issue has been automatically marked as stale. If this issue is still affecting you with the latest version, please leave any comment, and we will keep it open. We are sorry that we have not been able to prioritize it yet. If you have any new additional information, please include it with your comment!

@github-actions github-actions bot added the Resolution: Stale Issue or pull request is inactivity and unfortunately it will be *closed* if there is no response label Aug 28, 2024
Copy link

github-actions bot commented Sep 4, 2024

Closing this issue after a prolonged period of inactivity. If this issue is still present in the latest release, please create a new issue with up-to-date information. Thank you for your understanding!

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Resolution: Stale Issue or pull request is inactivity and unfortunately it will be *closed* if there is no response Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

No branches or pull requests

4 participants