Tree: Impossible to get tree node's element (data-id attribute absent)

[kheos31]

Describe the bug

Hello PrimeNG team,

Tree component lost its attribute data-id on each tree node element. It's really embarassing because we cannot tell to a third party library that it have to be plugged on a given node's HTML element... (like popover, etc...)
This attribute was lost here : 12d79f7

An existing issue corresponding to this bug was closed by error (I suppose, because this bug is still present in code) : #14541

A PR was also opened by @adyeardley to correct this issue : #14552

Also, your function focusVirtualNode (

primeng/src/app/components/tree/tree.ts

Line 701 in fd18d96

focusVirtualNode() {

) can't works with this data-id attribute missing. Impact on expand and collapse functions as I could see.

Can you please reopen this little PR and merge it please? Or just add again this attribute on node's element.

Thanks in advance and have a nice day.

Environment

Angular 17 application

Reproducer

No response

Angular version

17.2.2

PrimeNG version

17.10.0

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

20.11.1

Browser(s)

Chrome 122

Steps to reproduce the behavior

1. Go to https://primeng.org/tree
2. Check that each code examples have a "key" attribute in its node data
3. Check on the page, no data-id attribute is present

Expected behavior

Each node's element have to got a data-id attribute corresponding to its key property.

[kheos31]

PR opened with the lost attribute #15021

[adyeardley]

Thanks for this! I can confirm it is still causing problems for us and we have been unable to migrate to Prime v17, as it breaks a lot of our Automation tests, which is very important to the stability of our application.

[luke6040]

Yep same for me, we are pretty stuck until this is fixed. Just so there is no confusion again, it was closed because a fix was coming in vue, but we don't use that so wont help :(

[cetincakiroglu]

Fixed in #15021 until the PassThrough arrives. You'll be able to pass any attribute you want with PassThrough which is in implementation progress right now.

[cetincakiroglu]

This issue is fixed in 17.11.0, closing the issue and update the milestone.