Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

p-chip: Image does not have an alt attribute #15000

Closed
TaneliTuomola opened this issue Mar 11, 2024 · 1 comment · Fixed by #15008
Closed

p-chip: Image does not have an alt attribute #15000

TaneliTuomola opened this issue Mar 11, 2024 · 1 comment · Fixed by #15008
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Milestone

Comments

@TaneliTuomola
Copy link

Describe the bug

Without the empty alt attribute, a screen reader may read the file name. This will make no sense, and will confuse the user.
https://www.w3.org/WAI/tutorials/images/decorative/

Environment

primeNg 17.10.0

https://primeng.org/chip#image

Reproducer

No response

Angular version

17.0.0

PrimeNG version

17.10.0

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

18.16.0

Browser(s)

No response

Steps to reproduce the behavior

https://primeng.org/chip#image

Expected behavior

No response

@TaneliTuomola TaneliTuomola added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Mar 11, 2024
@SoyDiego
Copy link
Contributor

Hi, I created a PR fixing the problem.
You can check here #15008. Now we should wait PrimeNG Team approve it if it's ok for them.

Thanks! :)

@cetincakiroglu cetincakiroglu added Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Mar 14, 2024
@cetincakiroglu cetincakiroglu added this to the 17.11.0 milestone Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants