Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ColorPicker: Form elements must have labels #14974

Closed
HellinSunWTW opened this issue Mar 7, 2024 · 1 comment
Closed

ColorPicker: Form elements must have labels #14974

HellinSunWTW opened this issue Mar 7, 2024 · 1 comment

Comments

@HellinSunWTW
Copy link

Describe the bug

The Axe Dev Tools for Accessibility is reporting that the 'Form elements must have labels'.
image
Can we have appropriate aria label like "Color picker" added please?

Environment

Windows 10

Reproducer

No response

Angular version

17.2.3

PrimeNG version

17.9.0

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

18.18.0

Browser(s)

No response

Steps to reproduce the behavior

No response

Expected behavior

No response
@HellinSunWTW HellinSunWTW added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Mar 7, 2024
@cetincakiroglu cetincakiroglu added this to the 17.11.0 milestone Mar 8, 2024
@cetincakiroglu cetincakiroglu self-assigned this Mar 13, 2024
@cetincakiroglu cetincakiroglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working Component: Accessibility Issue or pull request is related to WCAG or ARIA and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Mar 13, 2024
@cetincakiroglu
Copy link
Contributor

Hi,

It seems that the issue is already fixed in previous versions. You can see below there is an aria-label bonded to the input. Closing the issue.

primeng/src/app/components/colorpicker/colorpicker.ts

Line 46 in 6c9a863

[attr.aria-label]="ariaLabel"

@cetincakiroglu cetincakiroglu removed this from the 17.11.0 milestone Mar 13, 2024
@cetincakiroglu cetincakiroglu removed Type: Bug Issue contains a bug related to a specific component. Something about the component is not working Component: Accessibility Issue or pull request is related to WCAG or ARIA labels Mar 13, 2024
@cetincakiroglu cetincakiroglu removed their assignment Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cetincakiroglu @HellinSunWTW