Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multiselect: Accesibility - no label for "toggle all" div and "filter" text box #14945

Closed
markuczy opened this issue Mar 5, 2024 · 1 comment · Fixed by #15143
Closed

Multiselect: Accesibility - no label for "toggle all" div and "filter" text box #14945

markuczy opened this issue Mar 5, 2024 · 1 comment · Fixed by #15143
Labels
Component: Accessibility Issue or pull request is related to WCAG or ARIA Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone
17.13.0

Comments

@markuczy
Copy link

markuczy commented Mar 5, 2024

Describe the bug

MultiSelect component do not have labels set for the following elements.

"Toggle all" div checkbox. Screenshot of the accessibility checker report from documentation (https://primeng.org/multiselect)
image

"Filter" input textbox. Screenshot of the accessibility checker report from documentation (https://primeng.org/multiselect)
image

Environment

Ubuntu 22.04, WSL 2, Windows 11 PRO

Reproducer

No response

Angular version

15.2.10

PrimeNG version

17.9.0

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

18.18.0

Browser(s)

No response

Steps to reproduce the behavior

No response

Expected behavior

Expected MultiSelect component to not report any issues with accessibility
@markuczy markuczy added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Mar 5, 2024
@markuczy markuczy changed the title Multiselect: Acceesibility - no label for "toggle all" div and "filter" text box Multiselect: Accesibility - no label for "toggle all" div and "filter" text box Mar 5, 2024
@mehmetcetin01140 mehmetcetin01140 added Component: Accessibility Issue or pull request is related to WCAG or ARIA and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Mar 18, 2024
TaneliTuomola pushed a commit to TaneliTuomola/primeng that referenced this issue Mar 22, 2024
fix primefaces#14945 MultiSelect toggleAllAriaLabel
d3c0966
@TaneliTuomola TaneliTuomola mentioned this issue Mar 22, 2024
Merged
@TaneliTuomola
Copy link

Aria-label for filter text box: https://primeng.org/multiselect#api.multiselect.props.ariaFilterLabel

@cetincakiroglu cetincakiroglu added this to the 17.13.0 milestone Mar 22, 2024
@cetincakiroglu cetincakiroglu added the Type: Bug Issue contains a bug related to a specific component. Something about the component is not working label Mar 22, 2024
cetincakiroglu added a commit that referenced this issue Mar 22, 2024
@cetincakiroglu
Merge pull request #15143 from TaneliTuomola/issue-14945
7e17d57 
fix #14945 MultiSelect toggleAllAriaLabel
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Component: Accessibility Issue or pull request is related to WCAG or ARIA Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Milestone
17.13.0
Development

Successfully merging a pull request may close this issue.

fix #14945 MultiSelect toggleAllAriaLabel TaneliTuomola/primeng
4 participants
@cetincakiroglu @TaneliTuomola @mehmetcetin01140 @markuczy