Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ColorPicker: Form elements must have labels #14941

Closed
WTW-Steve-Martin opened this issue Mar 4, 2024 · 0 comments · Fixed by #14947
Closed

ColorPicker: Form elements must have labels #14941

WTW-Steve-Martin opened this issue Mar 4, 2024 · 0 comments · Fixed by #14947
Assignees
@mehmetcetin01140
Labels
Component: Accessibility Issue or pull request is related to WCAG or ARIA PRO Support Issue was reported by PRO User Type: Bug Issue contains a bug related to a specific component. Something about the component is not working Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Milestone
17.10.0

Comments

@WTW-Steve-Martin
Copy link

Describe the bug

The Axe Dev Tools for Accessibility is reporting the following issue:
image

Axe is highlighting that the color picker doesn't have an Aria Label.

Please could we update this control so that the Axe scan passes?

Environment

Windows 10

Reproducer

No response

Angular version

17.2.3

PrimeNG version

17.9.0

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

18.18.0

Browser(s)

No response

Steps to reproduce the behavior

  1. Install the Axe Dev Tools for Accessibility plug-in.
  2. Visit the PrimeNG dropdown page (https://primeng.org/colorpicker) on Chrome/Edge browser.
  3. Scan the page with Axe

Expected behavior

The Axe scan doesn't return this error.
@WTW-Steve-Martin WTW-Steve-Martin added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Mar 4, 2024
@cetincakiroglu cetincakiroglu added this to the 17.10.0 milestone Mar 5, 2024
@cetincakiroglu cetincakiroglu added PRO Support Issue was reported by PRO User Component: Accessibility Issue or pull request is related to WCAG or ARIA labels Mar 5, 2024
mehmetcetin01140 added a commit that referenced this issue Mar 5, 2024
@mehmetcetin01140
Fixed #14941 - ColorPicker | Form elements must have labels
d603490
@mehmetcetin01140 mehmetcetin01140 mentioned this issue Mar 5, 2024
Merged
@cetincakiroglu cetincakiroglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Mar 6, 2024
cetincakiroglu added a commit that referenced this issue Mar 6, 2024
@cetincakiroglu
Merge pull request #14947 from primefaces/issue-14941
4459194 
Fixed #14941 - ColorPicker | Form elements must have labels
@cetincakiroglu cetincakiroglu added LTS-16-PORTABLE Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add labels Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mehmetcetin01140 mehmetcetin01140

Labels
Component: Accessibility Issue or pull request is related to WCAG or ARIA PRO Support Issue was reported by PRO User Type: Bug Issue contains a bug related to a specific component. Something about the component is not working Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Projects
None yet
Milestone
17.10.0
Development

Successfully merging a pull request may close this issue.

Fixed #14941 - ColorPicker | Form elements must have labels primefaces/primeng
3 participants
@cetincakiroglu @mehmetcetin01140 @WTW-Steve-Martin