Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

treetable, treeselect: wrong type information in jsdoc for node events #14939

Closed
can-oezkan opened this issue Mar 4, 2024 · 0 comments · Fixed by #14940
Closed

treetable, treeselect: wrong type information in jsdoc for node events #14939

can-oezkan opened this issue Mar 4, 2024 · 0 comments · Fixed by #14940
Labels
Component: Documentation Issue or pull request is related to Documentation
Milestone

Comments

@can-oezkan
Copy link
Contributor

/**
* Callback to invoke when a node is expanded.
* @param {TreeTableNode} object - Node instance.
* @group Emits
*/
@Output() onNodeExpand: EventEmitter<TreeTableNodeExpandEvent> = new EventEmitter<TreeTableNodeExpandEvent>();

/**
* Callback to invoke when a node is unselected.
* @param {TreeNode} node - Node instance.
* @group Emits
*/
@Output() onNodeUnselect: EventEmitter<TreeNodeUnSelectEvent> = new EventEmitter<TreeNodeUnSelectEvent>();

/**
* Callback to invoke when a node is selected.
* @param {TreeNode} node - Node instance.
* @group Emits
*/
@Output() onNodeSelect: EventEmitter<TreeNodeSelectEvent> = new EventEmitter<TreeNodeSelectEvent>();

the type documentation in @param differs from the typescript type.

@github-actions github-actions bot added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Mar 4, 2024
@can-oezkan can-oezkan changed the title wrong type information in jsdoc treetable, treeselect: wrong type information in jsdoc for node events Mar 4, 2024
@cetincakiroglu cetincakiroglu added this to the 17.10.0 milestone Mar 7, 2024
@cetincakiroglu cetincakiroglu added Component: Documentation Issue or pull request is related to Documentation and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Mar 7, 2024
cetincakiroglu added a commit that referenced this issue Mar 7, 2024
Fixed #14939 - TreeTable, TreeSelect | Fix jsdoc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Documentation Issue or pull request is related to Documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants