Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checkmark is visible when InputSwitch is set to checked in md-dark-theme #14921

Closed
esthersoftwaredev opened this issue Mar 1, 2024 · 8 comments · Fixed by #14922
Closed

Checkmark is visible when InputSwitch is set to checked in md-dark-theme #14921

esthersoftwaredev opened this issue Mar 1, 2024 · 8 comments · Fixed by #14922
Labels
Resolution: Cannot Replicate Issue could not be replicated by Core Team Resolution: Needs More Information More information about the issue is needed to find a correct solution Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible

Comments

@esthersoftwaredev
Copy link
Contributor

Describe the bug

The checkmark is visible when the input switch has a state of checked - md-dark theme

image

Environment

localhost
chrome browser

Reproducer

No response

Angular version

17

PrimeNG version

17

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

18

Browser(s)

No response

Steps to reproduce the behavior

No response

Expected behavior

No response

@esthersoftwaredev esthersoftwaredev added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Mar 1, 2024
@mehmetcetin01140 mehmetcetin01140 added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Mar 4, 2024
@cetincakiroglu cetincakiroglu added this to the 17.10.0 milestone Mar 7, 2024
cetincakiroglu added a commit that referenced this issue Mar 7, 2024
Fixed #14921 Hiding the checkmark of InputSwitch md-dark theme
cetincakiroglu added a commit that referenced this issue Mar 7, 2024
Revert "Fixed #14921 Hiding the checkmark of InputSwitch md-dark theme"
@cetincakiroglu cetincakiroglu reopened this Mar 7, 2024
@cetincakiroglu cetincakiroglu modified the milestones: 17.10.0, 17.11.0 Mar 7, 2024
@github-actions github-actions bot added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Mar 7, 2024
@cetincakiroglu
Copy link
Contributor

Hi,

I've reverted your fix because we couldn't replicate the behavior. Could you please create a stackblitz example or a screen recording so we can identify the issue?

@cetincakiroglu
Copy link
Contributor

I'm moving the issue to the next milestone until receiving a reproducer.

@cetincakiroglu cetincakiroglu modified the milestones: 17.11.0, 17.12.0 Mar 13, 2024
@cetincakiroglu cetincakiroglu added Resolution: Needs More Information More information about the issue is needed to find a correct solution and removed Type: Bug Issue contains a bug related to a specific component. Something about the component is not working labels Mar 13, 2024
@esthersoftwaredev
Copy link
Contributor Author

esthersoftwaredev commented Mar 13, 2024

@cetincakiroglu hi sorry I though I saw it as merged, I will try to stackblitz it,
in the meantime I can show you the - deployed app
and the relevant code in my public repo for that app

if you just uncheck the style I've added in chrome tools you will see it

@cetincakiroglu
Copy link
Contributor

I don't see any issue in your app. Please let me know when the stackblitz is ready.

Screenshot 2024-03-19 at 09 37 13

@esthersoftwaredev
Copy link
Contributor Author

esthersoftwaredev commented Mar 19, 2024

@cetincakiroglu I spotted the issue on my app, fixed it and then I decided to share the same fix over here.

But between me documenting the issue, my initial PR getting merged with the styles I added, the issue marked as completed and now - relevant styles have been applied to primefaces, which were not present when I created the issue

image

slightly different placement than what I submitted initially but same element, same issue and it's all fine now 👍

@cetincakiroglu
Copy link
Contributor

Hi,

Is this issue really exist or still ongoing, or are you experiencing this problem due to a change in your code? The issue is not clear, and we cannot replicate it with the latest version (v17.11.0). Could you please share a StackBlitz example demonstrating the issue?

@cetincakiroglu cetincakiroglu modified the milestones: 17.12.0, 17.13.0 Mar 19, 2024
@esthersoftwaredev
Copy link
Contributor Author

@monacodelisa close it

@cetincakiroglu cetincakiroglu modified the milestones: 17.13.0, 17.14.0 Apr 9, 2024
@cetincakiroglu cetincakiroglu added the Resolution: Cannot Replicate Issue could not be replicated by Core Team label Apr 18, 2024
@cetincakiroglu cetincakiroglu removed this from the 17.14.0 milestone Apr 18, 2024
Copy link

We're unable to replicate your issue, if you are able to create a reproducer by using PrimeNG Issue Template or add details please edit this issue. This issue will be closed if no activities in 20 days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Resolution: Cannot Replicate Issue could not be replicated by Core Team Resolution: Needs More Information More information about the issue is needed to find a correct solution Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants