Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Password: (accessiblility) cannot access toggle button using keyboard #14914

Closed
akshayaqburst opened this issue Feb 29, 2024 · 1 comment
Closed

Comments

@akshayaqburst
Copy link
Contributor

Describe the bug

focus cannot be moved to Password's toggle button, then cannot toggle using keyboard

Environment

Any env

Reproducer

No response

Angular version

13

PrimeNG version

17.9

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

18

Browser(s)

No response

Steps to reproduce the behavior

  1. go to Password toggle show case : https://primeng.org/password#togglemask
  2. use tab to set focus on password field
  3. hit tab several times, focus is never set on toggle password button

Expected behavior

Toggle button should be able to be activated using keyboard
Focus should also stay on toggle button when password state is toggled.

@akshayaqburst akshayaqburst added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Feb 29, 2024
akshayaqburst pushed a commit to qburst/primeng_qb_5 that referenced this issue Feb 29, 2024
akshayaqburst pushed a commit to qburst/primeng_qb_5 that referenced this issue Feb 29, 2024
@mehmetcetin01140 mehmetcetin01140 added Component: Accessibility Issue or pull request is related to WCAG or ARIA and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Mar 4, 2024
@cetincakiroglu cetincakiroglu added this to the 17.11.0 milestone Mar 7, 2024
@cetincakiroglu
Copy link
Contributor

Hi,

It's made by design, the toggle icon will not receive a tab index. However, we're implementing PassThrough, enabling users to give whatever attribute they want to any element of the component. I'm closing the issue, PassThrough is in the implementation process right now, and we're planning to release PassThrough for all components within v17.

Closing the issue.

@cetincakiroglu cetincakiroglu removed the Component: Accessibility Issue or pull request is related to WCAG or ARIA label Mar 13, 2024
@cetincakiroglu cetincakiroglu removed this from the 17.11.0 milestone Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants