Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Theming: Wrong Icon in documentation #14872

Closed
shaman-apprentice opened this issue Feb 25, 2024 · 0 comments · Fixed by #14877
Closed

Theming: Wrong Icon in documentation #14872

shaman-apprentice opened this issue Feb 25, 2024 · 0 comments · Fixed by #14877
Assignees
@mehmetcetin01140
Labels
Component: Documentation Issue or pull request is related to Documentation
Milestone
17.9.0

Comments

@shaman-apprentice
Copy link
Contributor

Describe the bug

In Theming Built-in Themes section the referenced Icon from topbar was replaced.

image

BTW:
Thanks for your great work! I couldn't find a public repository for the documentation. Otherwise I would have made a little PR for the fix as well ;)

Environment

Documentation

Reproducer

No response

Angular version

17.x.x

PrimeNG version

17.8.0

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

20.x.x

Browser(s)

No response

Steps to reproduce the behavior

No response

Expected behavior

No response
@shaman-apprentice shaman-apprentice added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Feb 25, 2024
@mehmetcetin01140 mehmetcetin01140 added Component: Documentation Issue or pull request is related to Documentation and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Feb 26, 2024
@mehmetcetin01140 mehmetcetin01140 added this to the 17.9.0 milestone Feb 26, 2024
@mehmetcetin01140 mehmetcetin01140 self-assigned this Feb 26, 2024
mehmetcetin01140 added a commit that referenced this issue Feb 26, 2024
@mehmetcetin01140
Fixed #14872 - Theming | Wrong Icon in documentation
8411c35
@mehmetcetin01140 mehmetcetin01140 mentioned this issue Feb 26, 2024
Merged
cetincakiroglu added a commit that referenced this issue Feb 27, 2024
@cetincakiroglu
Merge pull request #14877 from primefaces/issue-14872
2a9cb2d 
Fixed #14872 - Theming | Wrong Icon in documentation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mehmetcetin01140 mehmetcetin01140

Labels
Component: Documentation Issue or pull request is related to Documentation
Projects
None yet
Milestone
17.9.0
Development

Successfully merging a pull request may close this issue.

Fixed #14872 - Theming | Wrong Icon in documentation primefaces/primeng
2 participants
@shaman-apprentice @mehmetcetin01140