Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TabMenu: TabChange doesn't update Inkbar #14867

Closed
mirinio opened this issue Feb 23, 2024 · 0 comments · Fixed by #14895
Closed

TabMenu: TabChange doesn't update Inkbar #14867

mirinio opened this issue Feb 23, 2024 · 0 comments · Fixed by #14895
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@mirinio
Copy link

mirinio commented Feb 23, 2024

Describe the bug

TabMenu Component Inkbar logic isn't fully supported by all themes.

Environment

"@angular/animations": "17.2.1",
"@angular/cdk": "17.2.0",
"@angular/common": "17.2.1",
"@angular/compiler": "17.2.1",
"@angular/core": "17.2.1",
"@angular/forms": "17.2.1",
"@angular/platform-browser": "17.2.1",
"@angular/platform-browser-dynamic": "17.2.1",
"@angular/router": "17.2.1",
"@angular/service-worker": "17.2.1",
"primeflex": "^3.3.1",
"primeicons": "^6.0.1",
"primeng": "17.7.0",
"rxjs": "~7.8.1",
"tslib": "^2.6.2",
"zone.js": "0.14.4"

Reproducer

  1. https://primeng.org/tabmenu#controlled

Angular version

17.2.1

PrimeNG version

17.7.0

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

18.18.0

Browser(s)

Chrome

Steps to reproduce the behavior

  1. https://primeng.org/tabmenu#controlled
  2. Choose Theme => Material Design
  3. Click on Activate Last
    Result => Inkbar doesn't get updated

Expected behavior

  1. https://primeng.org/tabmenu#controlled
  2. Choose Theme => Material Design
  3. Click on Activate Last
    Result => Inkbar is updated
@mirinio mirinio added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Feb 23, 2024
@mehmetcetin01140 mehmetcetin01140 added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Feb 26, 2024
@mehmetcetin01140 mehmetcetin01140 added this to the 17.9.0 milestone Feb 26, 2024
cetincakiroglu added a commit that referenced this issue Feb 28, 2024
…kbar_for_material_design_theme

Fixed #14867 - Tab change inkbar for material design theme
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants