Cannot read properties of undefined (reading 'instance') at DialogService.getInstance

[sibinxsimelabs]

Describe the bug

getInstance method product Cannot read properties of undefined (reading 'instance') at DialogService.getInstance error. So component not displaying .
Same can be reproduce in PrimeNG dynamic dialog example

Environment

Development

Reproducer

https://stackblitz.com/edit/nga6lg

Angular version

17.1.X

PrimeNG version

17.7.X

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

18.9.0

Browser(s)

Edge

Steps to reproduce the behavior

1. Create Dynamic dialog
2. With/Without data
3. Inside constructor , try to call getInstace method

Expected behavior

It should not throw any error and show dynamic dialog component

[THammami01]

Encountering the same problem as well.

[salvatoremadonia]

same problem and i solved with:

this.instance = this.dialogService.dialogComponentRefMap.get(ref)?.instance;

[THammami01]

same problem and i solved with:

this.instance = this.dialogService.dialogComponentRefMap.get(ref)?.instance;

@salvatoremadonia Didn't solve it for me.

[eldonato]

If what you want is the config object passed on the dialogService.open method, you can workaround by passing a DynamicDialogConfig in the constructor of the component you're opening.

Something like this:

@Component({
  standalone: true,
  imports: [DynamicDialogModule],
  selector: 'app-dialog-test',
  providers: [DialogService],
  template: `<p>{{ config.data.message }}</p>`
})
export class DialogTestComponent {
  constructor(private ref: DynamicDialogRef, public config: DynamicDialogConfig ) { }
}

[THammami01]

Thanks! This solves the problem.

[B34v0n]

I got the same error, but my dialog shows it's content. My error is in the following method: https://github.com/primefaces/primeng/blob/master/src/app/components/dynamicdialog/dynamicdialog.ts#L329

loadChildComponent(componentType: Type<any>) {
        let viewContainerRef = this.insertionPoint?.viewContainerRef;
        viewContainerRef?.clear();

        this.componentRef = viewContainerRef?.createComponent(componentType);
        this.dialogRef.onChildComponentLoaded.next(this.componentRef!.instance);
    }

this.componentRef is undefined.

[tobika]

In case this helps someone, I completely forgot to import my custom dialog component (standalone) in the component that was opening the dialog. Angular rendered the template but it was not functional and there was no error in the console 😅

[bernhardpointner]

I got the same error, but my dialog shows it's content. My error is in the following method: https://github.com/primefaces/primeng/blob/master/src/app/components/dynamicdialog/dynamicdialog.ts#L329

loadChildComponent(componentType: Type<any>) {
        let viewContainerRef = this.insertionPoint?.viewContainerRef;
        viewContainerRef?.clear();

        this.componentRef = viewContainerRef?.createComponent(componentType);
        this.dialogRef.onChildComponentLoaded.next(this.componentRef!.instance);
    }

this.componentRef is undefined.

This problem still remains. viewContainerRef is optional and hence, also this.componentRef. Whereas in the last line, they assume with ".componentRef!.instance" that componentRef exists for sure.

[bernhardpointner]

Bug still is still there.

[rainergp]

Is there any fix or workaround for this bug so far?