Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Component: Autocomplete #14848

Closed
rekna1 opened this issue Feb 20, 2024 · 1 comment
Closed

Component: Autocomplete #14848

rekna1 opened this issue Feb 20, 2024 · 1 comment
Labels
Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible

Comments

@rekna1
Copy link

rekna1 commented Feb 20, 2024

Describe the bug

In previous version, when a space was entered, it would trigger a search. In current version it seems primeng does not search (I can see in the code of primeng this has been added ).
This is a breaking change, as we were relying in one particular case that space would trigger search. It would be better if primeng didn't change behaviour causing breaking changes. Instead provide a configuration option to specify whether or not to search on space, defaulting to the behaviour of the previous version (search on space)

Environment

  • windows
  • angular / primeng

Reproducer

No response

Angular version

17.0.7

PrimeNG version

17.6

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

20.10.0

Browser(s)

No response

Steps to reproduce the behavior

  1. type space in autocomplete
  2. no search is happing (was the case previous version)

Expected behavior

When space is pressed , default behaviour should be search.
Provide configuration option to opt in for not searching on space, so default behaviour does not break.

@rekna1 rekna1 added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Feb 20, 2024
@mehmetcetin01140
Copy link
Contributor

Hi,

So sorry for the delayed response! Improvements have been made to many components recently, both in terms of performance and enhancement. Therefore, this improvement may have been developed in another issue ticket without realizing it. You can check this in the documentation. If there is no improvement on this, can you open a new issue so we can include it in our roadmap?

Thanks a lot for your understanding!
Best Regards,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible
Projects
None yet
Development

No branches or pull requests

2 participants