Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

InputNumberInputEvent value type appears to be incorrect #14831

Closed
cetincakiroglu opened this issue Feb 19, 2024 · 2 comments · Fixed by #14878
Closed

InputNumberInputEvent value type appears to be incorrect #14831

cetincakiroglu opened this issue Feb 19, 2024 · 2 comments · Fixed by #14878
Assignees
@mehmetcetin01140
Labels
LTS-PORTABLE Issue's fix will be ported to supported LTS versions Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone
17.9.0

Comments

@cetincakiroglu
Copy link
Contributor

https://github.com/orgs/primefaces/discussions/1215
@cetincakiroglu cetincakiroglu added the Type: Bug Issue contains a bug related to a specific component. Something about the component is not working label Feb 19, 2024
@cetincakiroglu cetincakiroglu added this to the 17.9.0 milestone Feb 19, 2024
@github-actions github-actions bot added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Feb 19, 2024
mehmetcetin01140 added a commit that referenced this issue Feb 26, 2024
@mehmetcetin01140
Fixed #14831 - InputNumber | InputNumberInputEvent value type appears…
73ed19e 
… to be incorrect
@mehmetcetin01140 mehmetcetin01140 mentioned this issue Feb 26, 2024
Merged
@cetincakiroglu cetincakiroglu removed the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Feb 28, 2024
cetincakiroglu added a commit that referenced this issue Feb 28, 2024
@cetincakiroglu
Merge pull request #14878 from primefaces/issue-14831
1300df1 
Fixed #14831 - InputNumber | InputNumberInputEvent value type appears…
@adcore-dev
Copy link

One the latest changes on InputNumber broke it.
when the component loosing focus than the model become string instead number.

@cetincakiroglu cetincakiroglu added the LTS-PORTABLE Issue's fix will be ported to supported LTS versions label Mar 7, 2024
@Maksym-Onyshchenko
Copy link

@cetincakiroglu Hey, actually type of InputNumberInputEvent.value is "number | string", cause it can be string when there is nothing accept "-" (minus sign)
image

Would be good to make the type InputNumberInputEvent with generics, so it would know that if p-inputNumber value can be negative then InputNumberInputEvent.value would be "number | string", if p-inputNumber would accept only positive numbers (like when [min]=0) then InputNumberInputEvent.value is indeed "number"

@cetincakiroglu cetincakiroglu mentioned this issue Mar 19, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mehmetcetin01140 mehmetcetin01140

Labels
LTS-PORTABLE Issue's fix will be ported to supported LTS versions Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Milestone
17.9.0
Development

Successfully merging a pull request may close this issue.

Fixed #14831 - InputNumber | InputNumberInputEvent value type appears… primefaces/primeng
4 participants
@cetincakiroglu @adcore-dev @mehmetcetin01140 @Maksym-Onyshchenko