Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Component: p-dropdown emits changes when selected option did not change #14788

Closed
Airdevelopments opened this issue Feb 12, 2024 · 0 comments
Closed
Assignees
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@Airdevelopments
Copy link

Describe the bug

We recently updated from PrimeNG 15 to 17.

There seems to be a change in the behavior of the p-dropdown component:

Back in v15, when selecting the already selected option in a p-dropdown again, no change would be emitted. Now in v17 it does seem to do so.

The issue can be cruedly reproduced using the official component docs:

V15:
15_4 behavior

V17
17_6 behavior

The question is: Is this new desired behavior or a regression?

Environment

primeng: 17.6
angular: 17.1

Reproducer

No response

Angular version

17.1.0

PrimeNG version

17.6.0

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

18.16.0

Browser(s)

Chrome 120

Steps to reproduce the behavior

Open the docs on v15 and v17 as described above:

v15: https://www.primefaces.org/primeng-v15-lts/table#filter-row

v17: https://primeng.org/table#filter-row

Expected behavior

We would expect no emission of a change by p-dropdown when the already selected option is clicked again in the p-dropdown.

@Airdevelopments Airdevelopments added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Feb 12, 2024
@cetincakiroglu cetincakiroglu added this to the 17.7.0 milestone Feb 12, 2024
@cetincakiroglu cetincakiroglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Feb 13, 2024
@cetincakiroglu cetincakiroglu self-assigned this Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

No branches or pull requests

2 participants