Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Component: Chips | A chip generated on pressing enter key to confirm input #14720

Closed
zeatan opened this issue Feb 6, 2024 · 3 comments
Closed
Labels
Resolution: Needs More Information More information about the issue is needed to find a correct solution Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible

Comments

@zeatan
Copy link

zeatan commented Feb 6, 2024

Describe the bug

As per the video below, when pressing the enter key to confirm input, a new chip is created.
Before version 16.7.0, this behavior did not occur.

chips-bug.mov

Environment

win11/chrome latest, macOS12/chrome latest

Reproducer

No response

Angular version

17.1

PrimeNG version

17.5.0

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

18.19.0

Browser(s)

Chrome 121

Steps to reproduce the behavior

No response

Expected behavior

Not generate chip on pressing enter key to confirm input.

For example, use event.keyCode === 13 intead of event.code === 'Enter'

@zeatan zeatan added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Feb 6, 2024
@cetincakiroglu
Copy link
Contributor

Pressing enter adds new chip. It was working in the same way before https://www.primefaces.org/primeng-v15-lts/chips#basic

Could you please provide stackblitz example so we can identify the issue clearly?

@cetincakiroglu cetincakiroglu added the Resolution: Needs More Information More information about the issue is needed to find a correct solution label Feb 12, 2024
@zeatan
Copy link
Author

zeatan commented Feb 13, 2024

@cetincakiroglu

I tried making it.
it cannot be reproduced without input conversion (such as JP/CN/KR languages using IME).

Ver 17.6.0 below, has this problem
https://stackblitz.com/edit/github-4qo4pk

Ver 16.6.0 below, is correct behavior.
https://stackblitz.com/edit/bq8963

@mehmetcetin01140
Copy link
Contributor

Hi,

So sorry for the delayed response! Improvements have been made to many components recently, both in terms of performance and enhancement. Therefore, this improvement may have been developed in another issue ticket without realizing it. You can check this in the documentation. If there is no improvement on this, can you open a new issue so we can include it in our roadmap?

Thanks a lot for your understanding!
Best Regards,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Resolution: Needs More Information More information about the issue is needed to find a correct solution Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible
Projects
None yet
Development

No branches or pull requests

3 participants