Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

p-tabPanel is not closable when there's a p-calendar on the same page #14681

Closed
Da13Harris opened this issue Jan 31, 2024 · 1 comment
Closed
Labels
Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible

Comments

@Da13Harris
Copy link

Describe the bug

When a <p-tabPanel> component is used on the same page with a <p-calendar> component, the [closable]="true" flag displays the close icon, but when you click the icon it does not close the tab.

Environment

Windows 10

Reproducer

https://stackblitz.com/edit/github-s4q7be?file=src%2Fapp%2Fapp.component.ts,src%2Fapp%2Fapp.component.html

Angular version

17.1.1

PrimeNG version

17.4.0

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

18.16.1

Browser(s)

No response

Steps to reproduce the behavior

  1. Go to the stackblitz link provided.
  2. Click on the close icon on any of the tabs.

Expected behavior

The tabs should close when clicking the close icon, but they don't.

@Da13Harris Da13Harris added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Jan 31, 2024
@Da13Harris
Copy link
Author

Closing this issue. I just discovered that the code was fixed 5 days ago in #14606.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible
Projects
None yet
Development

No branches or pull requests

1 participant