Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Component: p-chips removal broken if a p-calendar is also loaded #14636

Closed
Xample opened this issue Jan 26, 2024 · 3 comments
Closed

Component: p-chips removal broken if a p-calendar is also loaded #14636

Xample opened this issue Jan 26, 2024 · 3 comments
Labels
Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible

Comments

@Xample
Copy link

Xample commented Jan 26, 2024

Describe the bug

I'm unable to remove any chip from the p-chips component if a p-calendar is loaded on the page.
The reason is: loading the p-calendar component will load it's own css "calendar.css" which contains the following style

    .p-icon-wrapper {
        pointer-events: none;
    }

and is NOT scoped to the calendar

it should probably be replaced with

    .p-calendar .p-icon-wrapper {
        pointer-events: none;
    }

Environment

windows, localhost but also on stackblitz

Reproducer

https://stackblitz.com/edit/fnvchf?file=src%2Fapp%2Fdemo%2Fchips-basic-demo.ts

Angular version

17.0.5

PrimeNG version

17.4.0

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

20.11.0

Browser(s)

No response

Steps to reproduce the behavior

  1. open the link: https://stackblitz.com/edit/fnvchf?file=src%2Fapp%2Fdemo%2Fchips-basic-demo.ts
    This is a fork of the official p-chips stackblit where I added a p-calendar and some default chips values.
  2. Try to either remove the tag or to clear the entire field.
  3. It won't work

Expected behavior

We should be able to both remove a chip or clear the entire field

@Xample Xample added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Jan 26, 2024
@Xample Xample changed the title Component: Title Component: p-chips removal broken if a p-calendar is also loaded Jan 26, 2024
@PranKe01
Copy link

It is even not working on primeng chips demo page witht the same css reason: https://primeng.org/chips

@thatsmeta
Copy link

thatsmeta commented Feb 1, 2024

This is a duplicate of #14606

@mehmetcetin01140
Copy link
Contributor

Hi,

So sorry for the delayed response! Improvements have been made to many components recently, both in terms of performance and enhancement. Therefore, this improvement may have been developed in another issue ticket without realizing it. You can check this in the documentation. If there is no improvement on this, can you open a new issue so we can include it in our roadmap?

Thanks a lot for your understanding!
Best Regards,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible
Projects
None yet
Development

No branches or pull requests

4 participants