Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tree: Child node counts included in node labels in v16 #14635

Closed
dnordahl1 opened this issue Jan 25, 2024 · 2 comments
Closed

Tree: Child node counts included in node labels in v16 #14635

dnordahl1 opened this issue Jan 25, 2024 · 2 comments
Labels
Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible

Comments

@dnordahl1
Copy link

Describe the bug

Maybe some debug line was released in the code? I don't see the same behavior in v15 or v17. It's currently observable on the demo page for p-tree: https://www.primefaces.org/primeng-v16-lts/tree

This isn't the case for v15 or v17.

Environment

N/A

Reproducer

https://stackblitz.com/edit/krqvgj

Angular version

16.2.0

PrimeNG version

16.9.4-lts

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

18.18.0

Browser(s)

ALL

Steps to reproduce the behavior

  1. Open https://www.primefaces.org/primeng-v16-lts/tree
  2. Notice child node counts are in the labels of every example shown. This isn't an intended feature as far as I can tell looking at the documentation pages.

Expected behavior

Child node counts shouldn't be automatically added to tree labels. This is especially problematic for lazy loaded trees.

A workaround seems to be to override the default template to just show the label. Ex:

<ng-template let-item pTemplate="default">
    <span>{{ item.label }}</span>
</ng-template>
@dnordahl1 dnordahl1 added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Jan 25, 2024
@mihilion
Copy link

mihilion commented Apr 8, 2024

It has been over two months, and noone has even answered? And the bug is clearly visible in every single case on the documentation page, so it is still present in latest 16.9.7-lts. The fix is probably as simple as modifying one line of code, come on.
@dnordahl1 Thanks for the workaround suggestion.

@mehmetcetin01140
Copy link
Contributor

Hi,

So sorry for the delayed response! Improvements have been made to many components recently, both in terms of performance and enhancement. Therefore, this improvement may have been developed in another issue ticket without realizing it. You can check this in the documentation. If there is no improvement on this, can you open a new issue so we can include it in our roadmap?

Thanks a lot for your understanding!
Best Regards,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible
Projects
None yet
Development

No branches or pull requests

3 participants