Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Component: Chips. No ability to limit max length of chip #14592

Closed
AndrewAKovalenko opened this issue Jan 19, 2024 · 2 comments · Fixed by #14593
Closed

Component: Chips. No ability to limit max length of chip #14592

AndrewAKovalenko opened this issue Jan 19, 2024 · 2 comments · Fixed by #14593
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Milestone
17.8.0

Comments

@AndrewAKovalenko
Copy link
Contributor

AndrewAKovalenko commented Jan 19, 2024 •
edited
Loading

Describe the bug

As for now, there is no ability to limit max length of value, that will be inserted into chip.
Proposal is to add maxLength property, that will limit number of characters that can be typed.

It will use input's native maxlength property
Benefit is improved UX and usage of standard HTML attributes

New @Input will be introduced, so no breaking changes

Environment

Chrome

Reproducer

No response

Angular version

17.0.4

PrimeNG version

17.3.3

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

20.10.0

Browser(s)

Chrome 120

Steps to reproduce the behavior

No response

Expected behavior

No response
@AndrewAKovalenko AndrewAKovalenko added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Jan 19, 2024
@AndrewAKovalenko AndrewAKovalenko mentioned this issue Jan 19, 2024
Merged
@cetincakiroglu cetincakiroglu added Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Jan 24, 2024
@AndrewAKovalenko
Copy link
Contributor Author

AndrewAKovalenko commented Jan 26, 2024 •
edited
Loading

implemented in #14593

but there's pipeline failing
maybe someone can help with fixing it?

@cetincakiroglu cetincakiroglu added this to the 17.8.0 milestone Feb 23, 2024
@christenbc
Copy link

The parameter maxLength has no effect whatsoever even though setting it. This does not work yet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Projects
None yet
Milestone
17.8.0
Development

Successfully merging a pull request may close this issue.

Fix #14592: Added maxLength property to p-chips component AndrewAKovalenko/primeng
3 participants
@AndrewAKovalenko @christenbc @cetincakiroglu