Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

p-table: "Date is after" filter does not exclude selected date #14589

Closed
psarno opened this issue Jan 19, 2024 · 3 comments
Closed

p-table: "Date is after" filter does not exclude selected date #14589

psarno opened this issue Jan 19, 2024 · 3 comments
Labels
Resolution: Stale Issue or pull request is inactivity and unfortunately it will be *closed* if there is no response Type: Bug Issue contains a bug related to a specific component. Something about the component is not working

Comments

@psarno
Copy link

psarno commented Jan 19, 2024

Describe the bug

When using a component with filtering, when selecting "Date After" and choosing a date, that date remains in the table, despite the fact it should only show dates after that date.

This can be seen even in the PrimeNG documentation example. In this case, "Date Is After" "09/12/2015" should not include that date in the result list, but it remains.

You have to select "Date is After" "09/13/2015" (the day after) if you actually want to exclude "09/12/2015".

image

image

Environment

PrimeNG 17.3.3
Angular 17.0.9

Reproducer

Can be reproduced on PrimeNG's documentation page for Table

Angular version

17.0.9

PrimeNG version

17.3.3

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

20.11.0

Browser(s)

No response

Steps to reproduce the behavior

  1. Open the filter on any date column
  2. Select "Date is After" as the filter type
  3. Enter a date that is displayed in the grid
  4. Click "Apply"

Expected behavior

The date selected in the date field should not be included in the result set, as it is not "after" itself.

@psarno psarno added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Jan 19, 2024
@psarno psarno changed the title p-table: "Date After" filter does not exclude selected date p-table: "Date is after" filter does not exclude selected date Jan 19, 2024
@mehmetcetin01140 mehmetcetin01140 added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Feb 5, 2024
@nbrown-ScottLogic
Copy link
Contributor

I think I have covered this bug in this PR: #15343

Copy link

This issue has been automatically marked as stale. If this issue is still affecting you with the latest version, please leave any comment, and we will keep it open. We are sorry that we have not been able to prioritize it yet. If you have any new additional information, please include it with your comment!

@github-actions github-actions bot added the Resolution: Stale Issue or pull request is inactivity and unfortunately it will be *closed* if there is no response label Aug 25, 2024
Copy link

github-actions bot commented Sep 1, 2024

Closing this issue after a prolonged period of inactivity. If this issue is still present in the latest release, please create a new issue with up-to-date information. Thank you for your understanding!

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Sep 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Resolution: Stale Issue or pull request is inactivity and unfortunately it will be *closed* if there is no response Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

No branches or pull requests

3 participants