Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Component: pCalendar: Date becomes empty string if dataType="string is specified #14574

Closed
fraras opened this issue Jan 17, 2024 · 4 comments
Closed
Labels
Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible

Comments

@fraras
Copy link

fraras commented Jan 17, 2024

Describe the bug

When changing a date inside a table with the p-calendar component, if the dataType="string" is specified the [(ngModel)] of the component returns an empty string instead of the date.

Environment

Angular

Reproducer

https://stackblitz.com/edit/github-y9uamu-cbuqcz?file=src%2Fapp%2Fapp.component.html

Angular version

17.0.7

PrimeNG version

17.3.2

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

18.17.0

Browser(s)

Chrome 120.0.6099.217

Steps to reproduce the behavior

  1. Build a p-table
  2. Add a p-calendar component into an editable field of the table
  3. Add the property dataType="string"
  4. Define the dates in the model as string
  5. Click on the date to open the Calendar

Expected behavior

The dates in the Date (Data Type String) column should be maintained in the calendar input box when clicked.

@fraras fraras added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Jan 17, 2024
@fraras fraras changed the title p-calendar: Date becomes empty string if dataType="string is specified Component: pCalendar: Date becomes empty string if dataType="string is specified Jan 17, 2024
@bhardwajsuresh
Copy link

Same issue with everyone with v17.4.0 as well. This should be fixed asap

@fbobbio
Copy link
Contributor

fbobbio commented May 19, 2024

Any news here?

@fbobbio
Copy link
Contributor

fbobbio commented May 19, 2024

Any news here?

Apparently solved.
Upgraded primeng to 17.17.0 and "@ngx-formly/primeng": "^6.2.2"

My angular version 17.0.6

@mehmetcetin01140
Copy link
Contributor

Hi,

So sorry for the delayed response! Improvements have been made to many components recently, both in terms of performance and enhancement. Therefore, this improvement may have been developed in another issue ticket without realizing it. You can check this in the documentation. If there is no improvement on this, can you open a new issue so we can include it in our roadmap?

Thanks a lot for your understanding!
Best Regards,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible
Projects
None yet
Development

No branches or pull requests

4 participants