Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MultiSelect: selectedItemsLabel is not localized (re-opened) #14554

Closed
puschie286 opened this issue Jan 15, 2024 · 5 comments
Closed

MultiSelect: selectedItemsLabel is not localized (re-opened) #14554

puschie286 opened this issue Jan 15, 2024 · 5 comments
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@puschie286
Copy link

puschie286 commented Jan 15, 2024

Describe the bug

selectedItemsLabel is not localized, but there is a translation entry for that: "selectionMessage"

Workaround: set selectedItemsLabel to inject( PrimeNGConfig ).getTranslation( 'selectionMessage' )

Environment

documentation

Reproducer

No response

Angular version

17

PrimeNG version

17.3.2

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

Browser(s)

No response

Steps to reproduce the behavior

  1. Use different translation
  2. Use MultiSelect with multiple items selected so that selectedItemsLabel is shown
  3. See selectedItemsLabel has not the selectionMessage translation value

Expected behavior

selectedItemsLabel should be default to "selectionMessage" translation

@puschie286 puschie286 added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Jan 15, 2024
@mertsincan
Copy link
Member

Thanks a lot for your report! I set a milestone and we'll check this issue before the milestone is released. Also, I really appreciate it if you support us with a PR.

Best Regards,

@mertsincan mertsincan added Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Jan 16, 2024
@mertsincan mertsincan added this to the 17.4.0 milestone Jan 16, 2024
@cetincakiroglu cetincakiroglu self-assigned this Jan 23, 2024
@cetincakiroglu
Copy link
Contributor

Hi @puschie286 ,

Thanks a lot for the report, we've just updated the selectedItemsLabel, could you please check it after the release and let us know if the issue persists?

@antoinesully
Copy link

antoinesully commented Jan 31, 2024

Hi @cetincakiroglu !

I have the same issue.
I updated to primeng 17.4.0.

I put this in the translation config (config.setTranslation({) :
image

Empty message is working as espected:
image

But the "selectionMessage" isn't working ...
image

Best regards,

PS: Or maybe it's possible to change the default "maxSelectedLabels" globally ? it could be interesting in my case.

@st55425 st55425 mentioned this issue Feb 5, 2024
@matusko89
Copy link

still persist, the fix #14712 would work, it needs to be released though :)

@cetincakiroglu cetincakiroglu reopened this Feb 7, 2024
@cetincakiroglu cetincakiroglu modified the milestones: 17.4.0, 17.7.0 Feb 7, 2024
@github-actions github-actions bot added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Feb 7, 2024
@cetincakiroglu cetincakiroglu modified the milestones: 17.7.0, 17.6.0 Feb 7, 2024
@cetincakiroglu cetincakiroglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add and removed Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible Type: Bug Issue contains a bug related to a specific component. Something about the component is not working labels Feb 7, 2024
@cetincakiroglu cetincakiroglu removed their assignment Feb 7, 2024
@cetincakiroglu cetincakiroglu changed the title MultiSelect: selectedItemsLabel is not localized MultiSelect: selectedItemsLabel is not localized (re-opened/bug) Feb 7, 2024
@cetincakiroglu cetincakiroglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add labels Feb 7, 2024
@cetincakiroglu cetincakiroglu changed the title MultiSelect: selectedItemsLabel is not localized (re-opened/bug) MultiSelect: selectedItemsLabel is not localized (re-opened) Feb 7, 2024
@antoinesully
Copy link

Hi !
It works perfectly !
Thank you :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

No branches or pull requests

5 participants