Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

p-columnfilter: missing aria-label #14537

Closed
TaneliTuomola opened this issue Jan 12, 2024 · 2 comments
Closed

p-columnfilter: missing aria-label #14537

TaneliTuomola opened this issue Jan 12, 2024 · 2 comments
Assignees
@cetincakiroglu
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone
17.3.3

Comments

@TaneliTuomola
Copy link

TaneliTuomola commented Jan 12, 2024 •
edited
Loading

The main ToggleButton (.p-column-filter-menu-button) still missing aria-label. Buttons inside filter menu (Apply & Clear) are ok now. Tested with primeNg 17.3.2: https://primeng.org/table#filter

Originally posted by @TaneliTuomola in #14272 (comment)
@github-actions github-actions bot added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Jan 12, 2024
@cetincakiroglu cetincakiroglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Jan 12, 2024
@cetincakiroglu cetincakiroglu added this to the 17.3.3 milestone Jan 12, 2024
@cetincakiroglu
Copy link
Contributor

Thanks a lot for reporting the issue!

@cetincakiroglu cetincakiroglu self-assigned this Jan 17, 2024
@cetincakiroglu cetincakiroglu added LTS-PORTABLE Issue's fix will be ported to supported LTS versions LTS-16-PORTABLE and removed LTS-PORTABLE Issue's fix will be ported to supported LTS versions labels Jan 19, 2024
@TaneliTuomola
Copy link
Author

The main ToggleButton still missing aria-label. There is wrong translation keys set in api.

@TaneliTuomola TaneliTuomola mentioned this issue Jan 23, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cetincakiroglu cetincakiroglu

Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Milestone
17.3.3
Development

No branches or pull requests
2 participants
@cetincakiroglu @TaneliTuomola