Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Calendar: Calendar Icon has a default cursor on hover #14501

Closed
navedqb opened this issue Jan 8, 2024 · 5 comments
Closed

Calendar: Calendar Icon has a default cursor on hover #14501

navedqb opened this issue Jan 8, 2024 · 5 comments
Assignees
@onursenture @dcyaner
Labels
Status: Discussion Issue or pull request needs to be discussed by Core Team
Milestone
17.3.3

Comments

@navedqb
Copy link
Contributor

navedqb commented Jan 8, 2024

Describe the bug

Calendar Icon has a default cursor on hover

https://primeng.org/calendar#icon

Environment

.

Reproducer

https://primeng.org/calendar#icon

Angular version

17

PrimeNG version

17.3.1

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

.

Browser(s)

No response

Steps to reproduce the behavior

  1. Go to https://primeng.org/calendar#icon
  2. Hover over the calendar icon
  3. Icon has a default cursor

Expected behavior

No response
@navedqb navedqb added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Jan 8, 2024
@navedqb navedqb mentioned this issue Jan 8, 2024
Closed
@SoyDiego
Copy link
Contributor

SoyDiego commented Jan 8, 2024

Maybe I'm wrong, but it is not necessary add cursor-pointer and it is correct the default cursor.

@mertsincan
Copy link
Member

Thanks a lot for your report and PR! We'll discuss it with our design team.

@mertsincan mertsincan added Status: Discussion Issue or pull request needs to be discussed by Core Team and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Jan 16, 2024
@mertsincan mertsincan added this to the 17.3.3 milestone Jan 16, 2024
@navedqb
Copy link
Contributor Author

navedqb commented Jan 16, 2024

Sure, thanks!

@onursenture
Copy link
Member

Having only the cursor: pointer is not sufficient. The input should also remain in the hover state. Looking at it from a behavior standpoint, because the date picker opens when we click on the icon, it should both have the cursor:pointer and remain in the input hover state.

@onursenture
Copy link
Member

We discussed with the team again; another solution is to give icon pointer-events: none, which will prevent confusion.

This was referenced Jan 23, 2024
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@onursenture onursenture

@dcyaner dcyaner

Labels
Status: Discussion Issue or pull request needs to be discussed by Core Team
Projects
None yet
Milestone
17.3.3
Development

Successfully merging a pull request may close this issue.

fix: add cursor pointer to calendar icon qburst/primeng-1
5 participants
@onursenture @mertsincan @SoyDiego @dcyaner @navedqb