Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Component: p-dataView v17.3 #14495

Closed
mcrightworks opened this issue Jan 6, 2024 · 2 comments
Closed

Component: p-dataView v17.3 #14495

mcrightworks opened this issue Jan 6, 2024 · 2 comments
Labels
Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible

Comments

@mcrightworks
Copy link

Describe the bug

After upgrading to v17. DataView no longer shows results.

Environment

"dependencies": { "@angular/animations": "^17.0.8", "@angular/common": "^17.0.8", "@angular/compiler": "^17.0.8", "@angular/core": "^17.0.8", "@angular/forms": "^17.0.8", "@angular/platform-browser": "^17.0.8", "@angular/platform-browser-dynamic": "^17.0.8", "@angular/router": "^17.0.8", "chart.js": "^4.4.1", "primeflex": "^3.3.1", "primeicons": "^6.0.1", "primeng": "^17.3.0", "rxjs": "~7.8.0", "tslib": "^2.3.0", "zone.js": "~0.14.2" },

Reproducer

No response

Angular version

17.0.8

PrimeNG version

17.3.0

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

20

Browser(s)

No response

Steps to reproduce the behavior

Implement a Dataview with latest primeng and angular. No code changes.
Also the DOCS are not reflecting a stackblitz with the latest v17. They are all still v16.

Expected behavior

No response

@mcrightworks mcrightworks added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Jan 6, 2024
@siddhareddy
Copy link
Contributor

If you have upgraded from PrimeNG 16 to 17.
There were breaking changes to p-dataView 17.0-rc1-breaking-changes .
You may need to change the templates names and data params as per the new docs
What's changed : 14214 - DataView | Remove primeflex dependency
I think the demo are working as expected stackblitz - dataview-demo-primeng-17.3.1

@mehmetcetin01140
Copy link
Contributor

Hi,

So sorry for the delayed response! Improvements have been made to many components recently, both in terms of performance and enhancement. Therefore, this improvement may have been developed in another issue ticket without realizing it. You can check this in the documentation. If there is no improvement on this, can you open a new issue so we can include it in our roadmap?

Thanks a lot for your understanding!
Best Regards,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible
Projects
None yet
Development

No branches or pull requests

3 participants