Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OverlayPanel: Accessibility documentation #14493

Closed
puschie286 opened this issue Jan 5, 2024 · 4 comments
Closed

OverlayPanel: Accessibility documentation #14493

puschie286 opened this issue Jan 5, 2024 · 4 comments
Labels
Component: Documentation Issue or pull request is related to Documentation Resolution: Stale Issue or pull request is inactivity and unfortunately it will be *closed* if there is no response

Comments

@puschie286
Copy link

Describe the bug

the documentation still says that the component add the aria attributes. as @cetincakiroglu mentioned, its the developer reponsibility to add these attributes

Environment

documentation

Reproducer

No response

Angular version

17

PrimeNG version

17.3.1

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

0

Browser(s)

No response

Steps to reproduce the behavior

No response

Expected behavior

No response

@puschie286 puschie286 added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Jan 5, 2024
@cetincakiroglu
Copy link
Contributor

You can use ariaLabel and ariaLabelledBy input properties.

    /**
     * Defines a string that labels the input for accessibility.
     * @group Props
     */
    @Input() ariaLabel: string | undefined;
    /**
     * Establishes relationships between the component and label(s) where its value should be one or more element IDs.
     * @group Props
     */
    @Input() ariaLabelledBy: string | undefined;

@puschie286
Copy link
Author

@cetincakiroglu can you please stop closing issues that are not complete...
the documentation still says : "OverlayPanel adds aria-expanded state attribute and aria-controls to the trigger so that the relation between the trigger and the popup is defined."

@cetincakiroglu cetincakiroglu reopened this Jan 8, 2024
@mehmetcetin01140 mehmetcetin01140 added Component: Documentation Issue or pull request is related to Documentation and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Jan 11, 2024
Copy link

This issue has been automatically marked as stale. If this issue is still affecting you with the latest version, please leave any comment, and we will keep it open. We are sorry that we have not been able to prioritize it yet. If you have any new additional information, please include it with your comment!

@github-actions github-actions bot added the Resolution: Stale Issue or pull request is inactivity and unfortunately it will be *closed* if there is no response label May 11, 2024
Copy link

Closing this issue after a prolonged period of inactivity. If this issue is still present in the latest release, please create a new issue with up-to-date information. Thank you for your understanding!

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale May 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Documentation Issue or pull request is related to Documentation Resolution: Stale Issue or pull request is inactivity and unfortunately it will be *closed* if there is no response
Projects
None yet
Development

No branches or pull requests

3 participants