Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MultiSelect: UpdateLabel() method missing #14343

Closed
mshnajar opened this issue Dec 13, 2023 · 5 comments
Closed

MultiSelect: UpdateLabel() method missing #14343

mshnajar opened this issue Dec 13, 2023 · 5 comments
Labels
Resolution: Invalid Issue or pull request is not valid in the latest version

Comments

@mshnajar
Copy link

mshnajar commented Dec 13, 2023

Describe the bug

I have updated my Angular to 16 & PrimeNG to 16.9.1
After the update I get this compile-time error:
Property 'updateLabel' does not exist on type 'MultiSelect'.
I traced the PrimeNG MultiSelect codes & realized that in the migration from 16.6.0 to 16.7.0 @cetincakiroglu had a big commit "MultiSelect | Accessibility Enhancements" (0cdb8bd) & the updateLabel() method was removed.
Could you please tell me what was the reason & also I don't remember what this method actually did (Legacy code)?
And what could be the alternative method instead of updateLabel()

Environment

Angular to 16
PrimeNG 16.9.1

Reproducer

No response

Angular version

16.2..12

PrimeNG version

16.9.1

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

18.10.0

Browser(s)

No response

Steps to reproduce the behavior

No response

Expected behavior

No response

@mshnajar mshnajar added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Dec 13, 2023
@cetincakiroglu
Copy link
Contributor

Hi,

With version 16.7.0, we have released the first part of the accessibility implementation for inputs that we have been working on for a long time. Based on the research we conducted during the implementation, we decided that many components needed changes in their structure and simplification, and these components were rewritten. UpdateLabel is one of the rewritten methods. You can download and check the code of previous releases as a zip file from the releases tab on the repo.

@cetincakiroglu cetincakiroglu added Resolution: Invalid Issue or pull request is not valid in the latest version and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Dec 13, 2023
@mshnajar
Copy link
Author

mshnajar commented Jan 7, 2024

As I mentioned above, I am using PrimeNG 16.9.1 & in this version we get compile error, telling that there is no method named UpdateLabel to call ( Error: Property 'updateLabel' does not exist on type 'MultiSelect' )
So what has happed to UpdateLabel method? Is it renamed or removed?
We used this method to clear the MultiSelect, selected items label & now we have commented this part of code!
Please guide us & give a possible solution for this problem @cetincakiroglu

@shamimkhan539
Copy link

As I mentioned above, I am using PrimeNG 16.9.1 & in this version we get compile error, telling that there is no method named UpdateLabel to call ( Error: Property 'updateLabel' does not exist on type 'MultiSelect' ) So what has happed to UpdateLabel method? Is it renamed or removed? We used this method to clear the MultiSelect, selected items label & now we have commented this part of code! Please guide us & give a possible solution for this problem @cetincakiroglu

I'm also facing similar issues!

@mshnajar
Copy link
Author

Based on my problem & others experience , I don't think immediate act on closing a really open issue is what is accepted.
@cetincakiroglu
@cagataycivici

@cetincakiroglu
Copy link
Contributor

cetincakiroglu commented Jan 13, 2024

Hi,

The updateLabel method was an undocumented method that was used within the component without any encouragement for users to use it. It is the user's responsibility to use an undocumented method and bear the consequences that may arise from it. Instead of this method, we are now using angular signals. Since it wasn't publicly mentioned or documented, removing was not a breaking change. The reason why we reworked the components is to make maintenance easier and make the code easier to comprehend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Resolution: Invalid Issue or pull request is not valid in the latest version
Projects
None yet
Development

No branches or pull requests

3 participants