Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dropdown: dynamic text in placeholder is not displayed #14320

Closed
dbelob opened this issue Dec 11, 2023 · 5 comments · Fixed by #14631
Closed

Dropdown: dynamic text in placeholder is not displayed #14320

dbelob opened this issue Dec 11, 2023 · 5 comments · Fixed by #14631
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@dbelob
Copy link

dbelob commented Dec 11, 2023

Describe the bug

The text in the placeholder is not displayed if it is generated dynamically using pipe.
primeng-dropdown-placeholder-error-invalid1

Environment

OS: Windows 8.1, Windows 10

Reproducer

https://stackblitz.com/github/dbelob/primeng-dropdown-placeholder-error

Angular version

17.1.2

PrimeNG version

17.5.0

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

v20.11.0

Browser(s)

Chrome 120.0.6099.71, Firefox 120.0.1, Edge 120.0.2210.61

Steps to reproduce the behavior

  1. Add p-dropdown with or without ng-template
  2. Use dynamic text in placeholder attribute (for example {{'selectCountry' | translate}})
  3. Open application in any browser: text will not appear
  4. Select other language (see example): text will not appear

Expected behavior

The text is successfully displayed in PrimeNG 16.6.0
https://stackblitz.com/github/dbelob/primeng-dropdown-placeholder-error/tree/primeng16.6.0

Text should be displayed after opening the application:
primeng-dropdown-placeholder-error-valid1

Text should change after changing the language:
primeng-dropdown-placeholder-error-valid2

@dbelob dbelob added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Dec 11, 2023
@dbelob
Copy link
Author

dbelob commented Dec 11, 2023

See same issue #14321

@mehmetcetin01140 mehmetcetin01140 added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Jan 5, 2024
@matusko89
Copy link

same issue here, aparently [placeholder]="value" is set only the first time and then is not detecting the change of the value

@danieljedrzejczyk
Copy link

danieljedrzejczyk commented Feb 2, 2024

@cetincakiroglu pls add multiselect bug to 17.6.0 milestone.
#14321

@cetincakiroglu
Copy link
Contributor

cetincakiroglu commented Feb 2, 2024

@danieljedrzejczyk

Thanks a lot for letting me know, I've added it now.

cetincakiroglu added a commit that referenced this issue Feb 7, 2024
Fix Dropdown: dynamic text in placeholder is not displayed fixes #14320
@McFck
Copy link

McFck commented Apr 14, 2024

@cetincakiroglu Greetings, can this PR be forwarded to primeng v16 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants