Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MultiSelect: selectionLimit & floating label regression #14299

Closed
PeterHewat opened this issue Dec 8, 2023 · 0 comments
Closed

MultiSelect: selectionLimit & floating label regression #14299

PeterHewat opened this issue Dec 8, 2023 · 0 comments
Assignees
Labels
LTS-PORTABLE Issue's fix will be ported to supported LTS versions PRO Support Issue was reported by PRO User Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@PeterHewat
Copy link

PeterHewat commented Dec 8, 2023

Describe the bug

MultiSelect: selectionLimit is no longer taken into account and floating label not going back down on an empty list.

Environment

All

Reproducer

16.6.0 MultiSelect selectionLimit & floating label used to work fine.
https://stackblitz.com/edit/7hukqt?file=src%2Fapp%2Fdemo%2Fmulti-select-floatlabel-demo.html

16.7.0 Introduced a regression
https://stackblitz.com/edit/7hukqt-uv8snr?file=src%2Fapp%2Fdemo%2Fmulti-select-floatlabel-demo.html

16.8.0 Partial fix
https://stackblitz.com/edit/7hukqt-3fzbxz?file=src%2Fapp%2Fdemo%2Fmulti-select-floatlabel-demo.html

17.0.0 Still not completly fixed
https://stackblitz.com/edit/v72ptq?file=src%2Fapp%2Fdemo%2Fmulti-select-floatlabel-demo.html

Angular version

17.0.0

PrimeNG version

17.0.0

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

20.9.0

Browser(s)

Chrome

Steps to reproduce the behavior

PrimeNG 16.6.0:

  • Select a city => the other cities become disabled (normal since selectionLimit=1).
  • Deselect that city and focus out => the floating label comes back down.
    => Pass

PrimeNG 17.0.0:

  • Select a city => the other cities don't become disabled (they should since selectionLimit=1).
  • Deselect that city and focus out => the floating label doesn't comes back down (it should). Deselect that city and focus out => the floating label comes back down.
    => Fail

Expected behavior

Should work as PrimeNG 16.6.0

@PeterHewat PeterHewat added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Dec 8, 2023
@cetincakiroglu cetincakiroglu added this to the 17.1.0 milestone Dec 8, 2023
@cetincakiroglu cetincakiroglu self-assigned this Dec 8, 2023
@cetincakiroglu cetincakiroglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Dec 8, 2023
@cetincakiroglu cetincakiroglu added LTS-PORTABLE Issue's fix will be ported to supported LTS versions PRO Support Issue was reported by PRO User labels Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
LTS-PORTABLE Issue's fix will be ported to supported LTS versions PRO Support Issue was reported by PRO User Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

No branches or pull requests

3 participants