Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Component: MultiSelect - Filter not working for grouped items #14278

Closed
jpgoelz opened this issue Dec 5, 2023 · 5 comments
Closed

Component: MultiSelect - Filter not working for grouped items #14278

jpgoelz opened this issue Dec 5, 2023 · 5 comments
Labels
Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible

Comments

@jpgoelz
Copy link

jpgoelz commented Dec 5, 2023

Describe the bug

When using grouped select items for the MultiSelect component, filtering no longer works, even for SelectItems that have a label property. It is now necessary to explicitly specify optionLabel="label", which is a regression.
The same is true for optionValue="value". The whole select item is being emitted, if this is not provided.

The problem can be seen in the demo for grouped items on the PrimeNG website: https://www.primefaces.org/primeng-v16/multiselect#group.

image

image

PrimeNG versions

16.9.1, 17.0.0

Build / Runtime

Angular CLI App

Language

TypeScript

Steps to reproduce the behavior

  1. Add a MultiSelect component with SelectItemGroup that use SelectItem[].
  2. Use the filter to filter for items. Nothing will be found.
  3. Add optionLabel="label" and optionValue="value" and try again. Elements will be found.

Expected behavior

When using default SelectItems, label and value should not need to be specified as an optionLabel resp. an optionValue.

@jpgoelz jpgoelz added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Dec 5, 2023
@jpgoelz
Copy link
Author

jpgoelz commented Dec 8, 2023

This problem persists in v17.

@jpgoelz
Copy link
Author

jpgoelz commented Dec 8, 2023

I updated the issue, because it also applies to optionValue="value".

@xRino94
Copy link

xRino94 commented May 6, 2024

Same problem with Dropdown component: filter doesn't work without explicit set optionLabel="label"

PrimeNg version: 17.12.0

@hemal-panchasara
Copy link

hemal-panchasara commented Jul 2, 2024

with optionLabel="label" it will filter but group name is not coming along with the label. primeng 17. angular 17.
Please anyone has solution to work around let post the solution here

@mertsincan
Copy link
Member

Hi,

So sorry for the delayed response! Improvements have been made to many components recently, both in terms of performance and enhancement. Therefore, this improvement may have been developed in another issue ticket without realizing it. You can check this in the documentation. If there is no improvement on this, can you reopen the issue so we can include it in our roadmap?
Please don't forget to add your feedback as a comment after reopening the issue. These will be taken into account by us and will contribute to the development of this feature. Thanks a lot for your understanding!

Best Regards,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible
Projects
None yet
Development

No branches or pull requests

4 participants