Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Component: Paginator Dropdown Accessibility in 16.9.1 #14260

Closed
GMacAussie opened this issue Nov 30, 2023 · 3 comments
Closed

Component: Paginator Dropdown Accessibility in 16.9.1 #14260

GMacAussie opened this issue Nov 30, 2023 · 3 comments

Comments

@GMacAussie
Copy link

Describe the bug

Running Accessibility Insights for Web (Microsoft) plugin on Basic Paginator Demo shows accessibility issues with the dropdown. See attached dropdown open/closed reports.
PrimeNG-16.9.1-PaginatorBasic-open.pdf
PrimeNG-16.9.1-PaginatorBasic-closed.pdf

Environment

Microsoft Edge Version 119.0.2151.72 (Official build) (64-bit)
Windows 10 Pro Version 10.0.19045 Build 19045

Reproducer

https://stackblitz.com/edit/k8ueix?file=package.json

Angular version

16.2.0

PrimeNG version

16.9.1

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

x.x.x

Browser(s)

No response

Steps to reproduce the behavior

  1. Run the Accessibility Insights for Web extension (Chrome or Edge) in the Basic Paginator page. It will report errors with the dropdown while closed
  2. Open the Paginator dropdown and restart Accessibility Insights for Web. It will report errors with the dropdown while open

Expected behavior

No accessibility issues are reported.

@GMacAussie GMacAussie added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Nov 30, 2023
@gauravpatni123
Copy link

@GMacAussie are you talking about this dropdown , when i don't have any records in the p-table then the dropdown is disabled by default for me

image

@GMacAussie
Copy link
Author

Hey @gauravpatni123 although the paginator is usually associated with a table, to demonstrate the issue I used the Basic Paginator demo at https://www.primefaces.org/primeng-v16/paginator which has the dropdown active no matter what (since it is only the paginator demo).

@cetincakiroglu cetincakiroglu added this to the 17.9.0 milestone Feb 28, 2024
@cetincakiroglu cetincakiroglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working Component: Accessibility Issue or pull request is related to WCAG or ARIA and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Feb 28, 2024
@cetincakiroglu
Copy link
Contributor

Hi,

Thanks for reporting the issue, this issue is covered in #14358 and it's fixed. I've tested with the extension you've mentioned and the issue does not exist anymore with c77dbbb

Closing the issue and removing from the milestone.

@cetincakiroglu cetincakiroglu removed this from the 17.9.0 milestone Feb 29, 2024
@cetincakiroglu cetincakiroglu removed Type: Bug Issue contains a bug related to a specific component. Something about the component is not working Component: Accessibility Issue or pull request is related to WCAG or ARIA labels Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants