Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BlockUI: entire page is blocked if "blocked" input contains true by default (even if a target is defined) #14230

Closed
Adrii77 opened this issue Nov 28, 2023 · 0 comments · Fixed by #14234
Closed

BlockUI: entire page is blocked if "blocked" input contains true by default (even if a target is defined) #14230

Adrii77 opened this issue Nov 28, 2023 · 0 comments · Fixed by #14234
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone
17.2.0

Comments

@Adrii77
Copy link

Adrii77 commented Nov 28, 2023 •
edited
Loading

Describe the bug

I reopen this issue : #11798

Environment

Angular 16 / PrimeNG 16 / Chrome / MacOS

Reproducer

https://stackblitz.com/edit/s1endm?file=src%2Fapp%2Fdemo%2Fblock-ui-basic-demo.html,src%2Fapp%2Fdemo%2Fblock-ui-basic-demo.ts

Angular version

16.2.11

PrimeNG version

16.9.0

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

16.20.0

Browser(s)

Chrome

Steps to reproduce the behavior

  1. Go here : https://stackblitz.com/edit/s1endm?file=src%2Fapp%2Fdemo%2Fblock-ui-basic-demo.html,src%2Fapp%2Fdemo%2Fblock-ui-basic-demo.ts

  2. See the all page is blocked by default (it should not).

Expected behavior

If blockUI is set to true by default and contains a target : target only should be blocked.
@Adrii77 Adrii77 added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Nov 28, 2023
@Adrii77 Adrii77 changed the title BlockUI: entire page is blocked if blockUI contains true by default (even if a target is defined) BlockUI: entire page is blocked if "blocked" input contains true by default (even if a target is defined) Nov 28, 2023
ashikjs added a commit to ashikjs/primeng that referenced this issue Nov 28, 2023
@ashikjs
fix: primefaces#14230 || BlockUI: entire page is blocked if "blocked"…
8f09ca0 
… input contains true by default
@ashikjs ashikjs mentioned this issue Nov 28, 2023
Merged
ashikjs added a commit to ashikjs/primeng that referenced this issue Nov 29, 2023
@ashikjs
fix: primefaces#14230 || BlockUI: entire page is blocked if "blocked"…
ca6cb7a 
… input contains true by default
ashikjs added a commit to ashikjs/primeng that referenced this issue Dec 11, 2023
@ashikjs
fix: primefaces#14230 || BlockUI: entire page is blocked if "blocked"…
cf17076 
… input contains true by default
@cetincakiroglu cetincakiroglu added this to the 17.2.0 milestone Dec 20, 2023
@cetincakiroglu cetincakiroglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Dec 20, 2023
cetincakiroglu added a commit that referenced this issue Dec 20, 2023
@cetincakiroglu
Merge pull request #14234 from ashikjs/issues-14230/blockui-break-oni…
4a9c09c 
…nitial-set-true

fix: #14230 || BlockUI: entire page is blocked if "blocked" input con…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Milestone
17.2.0
Development

Successfully merging a pull request may close this issue.

fix: #14230 || BlockUI: entire page is blocked if "blocked" input con… ashikjs/primeng
2 participants
@Adrii77 @cetincakiroglu