Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table: FilterMatchMode for boolean is CONTAINS, but should be EQUALS #14210

Closed
wertzui opened this issue Nov 27, 2023 · 1 comment
Closed

Table: FilterMatchMode for boolean is CONTAINS, but should be EQUALS #14210

wertzui opened this issue Nov 27, 2023 · 1 comment
Labels
Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible

Comments

@wertzui
Copy link

wertzui commented Nov 27, 2023

In this line, FilterMatchMode.EQUALS is only returned for "number", but not for "boolean".

else if (this.type === 'numeric') return FilterMatchMode.EQUALS;

For "boolean" it falls back to the default case of FilterMatchMode.CONTAINS which does not make sence for boolean types.

For "boolean" the FilterMatchMode should be FilterMatchMode.EQUALS.

@github-actions github-actions bot added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Nov 27, 2023
@mertsincan
Copy link
Member

Hi,

So sorry for the delayed response! Improvements have been made to many components recently, both in terms of performance and enhancement. Therefore, this improvement may have been developed in another issue ticket without realizing it. You can check this in the documentation. If there is no improvement on this, can you reopen the issue so we can include it in our roadmap?
Please don't forget to add your feedback as a comment after reopening the issue. These will be taken into account by us and will contribute to the development of this feature. Thanks a lot for your understanding!

Best Regards,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible
Projects
None yet
Development

No branches or pull requests

2 participants