Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Module: BrowserAnimationsModule compatibility #14207

Closed
Khumain opened this issue Nov 25, 2023 · 2 comments
Closed

Module: BrowserAnimationsModule compatibility #14207

Khumain opened this issue Nov 25, 2023 · 2 comments
Labels
Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible

Comments

@Khumain
Copy link

Khumain commented Nov 25, 2023

Describe the bug

Hello wonderful Team,

I noticed that with the new Angular 17 update and a full standalone app (no modules), I am unable to make animations work correctly. I tried the following configuration:

import { ApplicationConfig } from '@angular/core';
import { provideRouter } from '@angular/router';

import { routes } from './app.routes';
import {provideAnimationsAsync} from "@angular/platform-browser/animations/async";

export const appConfig: ApplicationConfig = {
  providers: [
    provideRouter(routes),
    provideAnimationsAsync()
  ]
};

but it does not seem to animate buttons (hover functionalities for example).

Environment

Windows 11
Node v18.17.1
Npm v8.16.0

Reproducer

No response

Angular version

17.0.3

PrimeNG version

17.0.0-beta.1

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

18.17.1

Browser(s)

Firefox 120.0

Steps to reproduce the behavior

Simply with <p-button label="Submit"></p-button>

Expected behavior

The button should show a pointer cursor and change its color on hover or click

@Khumain Khumain added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Nov 25, 2023
@Khumain Khumain changed the title Component: Button Module: BrowserAnimationsModule compatibility Nov 25, 2023
@cetincakiroglu
Copy link
Contributor

Hi,

We're using the same thing in our app.config.ts for PrimeNG Showcase. It works in our demos, maybe you're missing something, could you please check available guides of v17 in angular.dev

@Khumain
Copy link
Author

Khumain commented Nov 28, 2023

Hello @cetincakiroglu you were right, I forgot @import "primeng/resources/primeng.min.css" in my styles.css file. You guys are amazing, thank you for keeping such a great library up to date!

@Khumain Khumain closed this as completed Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible
Projects
None yet
Development

No branches or pull requests

2 participants