Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pMultiSelect: The maxSelectedLabels is set by default to 3 and is not undefinable, which is undesired for implementing the overflow ellipsis #14195

Closed
GeroSchaarmann opened this issue Nov 24, 2023 · 0 comments
Assignees
Labels
LTS-PORTABLE Issue's fix will be ported to supported LTS versions Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@GeroSchaarmann
Copy link

Describe the bug

In earlier versions, the maxSelectedLabels was undefined, simplifying overflow management. Additionally, when the maximum selected labels are reached, it changed to displaying "x selected items." It would be more preferable to show the items with an overflow ellipsis.

Environment

follow this stackblitz link to see

Reproducer

https://stackblitz.com/edit/github-eleua3-w79tvq

Angular version

16.2.12

PrimeNG version

16.9.0

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

16.14.0

Browser(s)

No response

Steps to reproduce the behavior

StackBlitz permits typos, resulting in maxSelectedLabels being set to undefined. Remove this parameter to observe the described behavior. It would be preferable to have undefined as the default or as an option. Therefore, the input type needs adjustment.

Expected behavior

No response

@GeroSchaarmann GeroSchaarmann added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Nov 24, 2023
@cetincakiroglu cetincakiroglu added the Type: Bug Issue contains a bug related to a specific component. Something about the component is not working label Nov 25, 2023
@cetincakiroglu cetincakiroglu added this to the 17.0.0-rc.1 milestone Nov 25, 2023
@cetincakiroglu cetincakiroglu removed the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Nov 25, 2023
@cetincakiroglu cetincakiroglu self-assigned this Nov 25, 2023
@cetincakiroglu cetincakiroglu added the LTS-PORTABLE Issue's fix will be ported to supported LTS versions label Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
LTS-PORTABLE Issue's fix will be ported to supported LTS versions Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

No branches or pull requests

3 participants