Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dropdown: Key events not correctly working when filter is enabled #14189

Closed
mrkshx opened this issue Nov 23, 2023 · 1 comment
Closed

Dropdown: Key events not correctly working when filter is enabled #14189

mrkshx opened this issue Nov 23, 2023 · 1 comment
Assignees
Milestone

Comments

@mrkshx
Copy link

mrkshx commented Nov 23, 2023

Describe the bug

When filter property is set to true, the key events "End" and "Home" are not working:
Instead the option focus will be lost.

Pressing Keys "End" and "Home" when filter is enabled

dropdown_filter_loosing_option_focus.mp4

Pressing Keys "End" and "Home" when filter is disabled

dropdown_no_filter_keeps_option_focus.mp4

Environment

16.9.0

Reproducer

https://stackblitz.com/edit/github-etxtni?file=src%2Fapp%2Fapp.component.html

Angular version

16.2.12

PrimeNG version

16.9.0

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

latest

Browser(s)

No response

Steps to reproduce the behavior

No response

Expected behavior

When filter is set to true, key event "End" and "Home" should move focus to first / last option like it is implemented when filter is disabled.

@mrkshx mrkshx added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Nov 23, 2023
@mehmetcetin01140 mehmetcetin01140 self-assigned this Feb 6, 2024
@mehmetcetin01140 mehmetcetin01140 added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Feb 6, 2024
@mehmetcetin01140 mehmetcetin01140 added this to the 17.6.0 milestone Feb 6, 2024
@cetincakiroglu
Copy link
Contributor

Hi,

When pressed in filter input, end and home keys should move the cursor to the start or the end. This functionality didn't exist in v16 because it lacked accessibility enhancements. We've introduced the keyboard support after the accessibility implementation for the input components in 16.5x. The behavior is correct and changes were made for the accessibility. When the user focuses on the list, the home and end keys move the focus to the first or the last element in the overlay.

Closing the issue since it's not a bug, it's intended behavior in accessibility.

@cetincakiroglu cetincakiroglu removed the Type: Bug Issue contains a bug related to a specific component. Something about the component is not working label Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants