Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AutoComplete: ArrowDown key no longer opens up the suggestions panel #14163

Closed
timandella opened this issue Nov 21, 2023 · 4 comments
Closed
Labels
Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible

Comments

@timandella
Copy link

Describe the bug

In PrimeNg 16.6.0, pressing the ArrowDown key in the AutoComplete control box would open up the suggestions panel with any previously loaded suggestions.

With 16.7.0 and above does not happen. You have to type some some actual text to get it to show. If you were to press ESC, the panel closes, and ArrowDown can no longer be used to show it again

Environment

Angular and PrimeNG, running on a Windows 11 box

Reproducer

https://stackblitz.com/edit/nrt6yx?file=package.json

Angular version

16.2.12

PrimeNG version

16.7.0

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

18.6.1

Browser(s)

Edge

Steps to reproduce the behavior

  1. Go to the Stackblitz page shown
  2. Click on the searchbox to focus on it
  3. Click the Arrow Down
  4. Type "un"
  5. Press ESC (to close the suggestion panel)
  6. Click the Arrow Down again

Expected behavior

For steps 3 and 6, the suggestions panel should appear, with a list of countries (For step 3, all countries should be listed. For step 6, the 3 matching countries would be listed).

The expected behaviour works fine in 16.6.0

@timandella timandella added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Nov 21, 2023
antonionesta added a commit to antonionesta/primeng that referenced this issue Nov 21, 2023
antonionesta added a commit to antonionesta/primeng that referenced this issue Dec 6, 2023
@timandella
Copy link
Author

I see there is a fix for this, but one that seems to be going nowhere (due to the Pull Request containing fixes for other things, it seems).

Would it help if I created a separate pull request, containing just the fix to auto-complete, and nothing else? (The issue is causing a hold-up where I work. We want to update to 17, but our tests fail due to this Arrow Down not working)

@cetincakiroglu
Copy link
Contributor

Hi,

It's made by design. We've updated all Prime UI Libraries during the accessibility implementation. This behavior is intended. Closing the issue.

@timandella
Copy link
Author

I don't suppose you could elaborate as to how removing this functionality is an accessibility improvement? It seems like it makes it less accessible. How could the drop down be opened (apart from having to typing a new letter, or delete on, unnecessarily)

Also, for dropdown control, when that has focus, pressing arrowdown opens the drop-down, so there seems to be some inconsistency here.

@RezaMakvandi
Copy link

RezaMakvandi commented Apr 15, 2024

same problem, I used Autocomplete component in all over my projects, and now by this update their functionality is broken. please fix this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible
Projects
None yet
3 participants