Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Component: p-multiSelect resetFilterOnHide issue #14134

Closed
Anesta94 opened this issue Nov 16, 2023 · 2 comments
Closed

Component: p-multiSelect resetFilterOnHide issue #14134

Anesta94 opened this issue Nov 16, 2023 · 2 comments
Assignees
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@Anesta94
Copy link
Contributor

Anesta94 commented Nov 16, 2023

Describe the bug

When resetFilterOnHide is enabled, the second opening of the overlay panel generates an exception. I believe the issue lies in the resetFilter method; the _filterValue property is set to null. In my opinion, it should be done like this: this._filterValue.set(null), since it is a Signal or by using the setter filterValue.

p-multiSelect-1
p-multiSelect-2

Environment

All

Reproducer

https://stackblitz.com/edit/pjvadj?file=src%2Fapp%2Fdemo%2Fmulti-select-basic-demo.html

Angular version

16.2.0

PrimeNG version

16.7.2

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

18.18.0

Browser(s)

No response

Steps to reproduce the behavior

  1. Click on p-multiSelect to open overlay panel
  2. Click outside to close overlay panel
  3. Click on p-multiSelect to open overlay panel

At this point the exception should be thrown in console.

Expected behavior

No response

@Anesta94 Anesta94 added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Nov 16, 2023
@Wozhizxy
Copy link

I have also encountered this issue, and I feel that it is a bug

Anesta94 added a commit to Anesta94/primeng that referenced this issue Nov 16, 2023
@cetincakiroglu
Copy link
Contributor

Hi,

Thanks a lot for reporting the issue!

@cetincakiroglu cetincakiroglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Nov 16, 2023
@cetincakiroglu cetincakiroglu added this to the 16.8.0 milestone Nov 16, 2023
@cetincakiroglu cetincakiroglu self-assigned this Nov 16, 2023
cetincakiroglu added a commit that referenced this issue Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

No branches or pull requests

3 participants