Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Primeng css #14116

Closed
a-zana opened this issue Nov 14, 2023 · 2 comments
Closed

Primeng css #14116

a-zana opened this issue Nov 14, 2023 · 2 comments
Labels
Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible

Comments

@a-zana
Copy link

a-zana commented Nov 14, 2023

Describe the bug

in the 'primeng/resources/primeng' there is:

  input[type='button'],
  input[type='submit'],
  input[type='reset'],
  input[type='file']::-webkit-file-upload-button,
  button {
      border-radius: 0;
  }

this css is too generic and have a deep impact with for example bootstrap (importing bootstrap with a layer and set the boostrap layer before primeng as have to be).

Environment

use bootstrap with primeng and try to use for exmple the bootstrap button-group

Reproducer

No response

Angular version

16.2.19

PrimeNG version

16.6.0

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

18.10.0

Browser(s)

Chrome 119

Steps to reproduce the behavior

No response

Expected behavior

It is better to do somenthing like:

[class^='p-'] {
    input[type='button'],
    input[type='submit'],
    input[type='reset'],
    input[type='file']::-webkit-file-upload-button,
    button {
        border-radius: 0;
    }
}

so to apply this rule only to the primeng components

@a-zana a-zana added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Nov 14, 2023
@egorbwork
Copy link

I agree, I encountered a similar problem with the buttons.

@mertsincan
Copy link
Member

Hi,

So sorry for the delayed response! Improvements have been made to many components recently, both in terms of performance and enhancement. Therefore, this improvement may have been developed in another issue ticket without realizing it. You can check this in the documentation. If there is no improvement on this, can you reopen the issue so we can include it in our roadmap?
Please don't forget to add your feedback as a comment after reopening the issue. These will be taken into account by us and will contribute to the development of this feature. Thanks a lot for your understanding!

Best Regards,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible
Projects
None yet
Development

No branches or pull requests

3 participants