Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in showcase rowexpanddoc.ts of documentation #14109

Closed
hugograf opened this issue Nov 14, 2023 · 0 comments · Fixed by #14111 or #14113
Closed

Error in showcase rowexpanddoc.ts of documentation #14109

hugograf opened this issue Nov 14, 2023 · 0 comments · Fixed by #14111 or #14113
Assignees
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working

Comments

@hugograf
Copy link
Contributor

Describe the bug

Line <td>{{ order.id }}</td> should be <td>{{ order.date }}</td> in src/app/showcase/doc/table/rowexpanddoc.ts:

<div class="p-3">
                                <p-table [value]="product.orders" dataKey="id">
                                    <ng-template pTemplate="header">
                                        <tr>
                                            <th pSortableColumn="id">Id <p-sortIcon field="price"></p-sortIcon></th>
                                            <th pSortableColumn="customer">Customer <p-sortIcon field="customer"></p-sortIcon></th>
                                            <th pSortableColumn="date">Date <p-sortIcon field="date"></p-sortIcon></th>
                                            <th pSortableColumn="amount">Amount <p-sortIcon field="amount"></p-sortIcon></th>
                                            <th pSortableColumn="status">Status <p-sortIcon field="status"></p-sortIcon></th>
                                            <th style="width: 4rem"></th>
                                        </tr>
                                    </ng-template>
                                    <ng-template pTemplate="body" let-order>
                                        <tr>
                                            <td>{{ order.id }}</td>
                                            <td>{{ order.customer }}</td>
                                            <td>{{ order.id }}</td>
                                            <td>{{ order.amount | currency : 'USD' }}</td>
                                            <td>
                                                <p-tag [value]="order.status" [severity]="getStatusSeverity(order.status)"></p-tag>
                                            </td>
                                            <td><p-button type="button" icon="pi pi-plus"></p-button></td>
                                        </tr>
                                    </ng-template>
                                    <ng-template pTemplate="emptymessage">
                                        <tr>
                                            <td colspan="6">There are no order for this product yet.</td>
                                        </tr>
                                    </ng-template>
                                </p-table>
                            </div>

Environment

Windows 11

Reproducer

No response

Angular version

16.X

PrimeNG version

16.7.1

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

18.16.0

Browser(s)

No response

Steps to reproduce the behavior

Demo of Row Expand does not show any data in expanded row.

Expected behavior

No response

@hugograf hugograf added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Nov 14, 2023
@cetincakiroglu cetincakiroglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Nov 14, 2023
cetincakiroglu added a commit that referenced this issue Nov 16, 2023
Fixed #14109 - RowExpandDoc | Fixed wrong object property
cetincakiroglu added a commit that referenced this issue Nov 16, 2023
fix: #14109 || Error in rowexpanddoc file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
3 participants