Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation: AnimationEvent_2 typo? #14071

Closed
kvchrissh opened this issue Nov 9, 2023 · 1 comment
Closed

Documentation: AnimationEvent_2 typo? #14071

kvchrissh opened this issue Nov 9, 2023 · 1 comment
Labels
Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible

Comments

@kvchrissh
Copy link

kvchrissh commented Nov 9, 2023

Describe the bug

Not a bug, but potential error in the documentation?
For example in the Calendar component, the onClose event type is AnimationEvent_2. In the Angular library project I'm working on with VS Code, I get no suggestion for this, instead a suggestion for AnimationEvent from Angular. But then the HTML file of the component that uses the Calendar complains about the type. AnimationEvent_2 also doesn't link to any type reference, when I click on it on the PrimeNG Calendar docs page. Is AnimationEvent_2 a typo or is it an error on my side? A quick google search didn't provide an answer.

Environment

VS Code 1.81.1

Reproducer

No response

Angular version

16.2.12

PrimeNG version

16.7.1

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

18.18.0

Browser(s)

No response

Steps to reproduce the behavior

No response

Expected behavior

No response

@kvchrissh kvchrissh added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Nov 9, 2023
@mertsincan
Copy link
Member

Hi,

So sorry for the delayed response! Improvements have been made to many components recently, both in terms of performance and enhancement. Therefore, this improvement may have been developed in another issue ticket without realizing it. You can check this in the documentation. If there is no improvement on this, can you reopen the issue so we can include it in our roadmap?
Please don't forget to add your feedback as a comment after reopening the issue. These will be taken into account by us and will contribute to the development of this feature. Thanks a lot for your understanding!

Best Regards,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible
Projects
None yet
Development

No branches or pull requests

2 participants