Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Any types in TreeTableLazyLoadEvent should be numbers #13987

Open
jpgoelz opened this issue Oct 31, 2023 · 3 comments
Open

Any types in TreeTableLazyLoadEvent should be numbers #13987

jpgoelz opened this issue Oct 31, 2023 · 3 comments
Labels
Resolution: Help Wanted Issue or pull request requires extra help and feedback
Milestone
Future

Comments

@jpgoelz
Copy link

jpgoelz commented Oct 31, 2023

Describe the bug

While Table now emits TableLazyLoadEvent through (onLazyLoad), TreeTable emits TreeTableLazyLoadEvent.

For some reason, Table correctly has firstand last of type number while TreeTable has the same properties, but of type any.

In every case I have tested, the values emitted were numbers and, I believe, it should be changed to that type. Otherwise, I do not know what to expect.

Environment

not relevant

Reproducer

No response

Angular version

16.2.11

PrimeNG version

16.6.0

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

18

Browser(s)

No response

Steps to reproduce the behavior

No response

Expected behavior

No response
@jpgoelz jpgoelz added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Oct 31, 2023
@github-actions GitHub Actions
Copy link

This issue has been automatically marked as stale due to a lack of activity. If this issue is still relevant to you, please leave a comment so we can keep it open. We apologize for not being able to prioritize it sooner. If you have any new information or questions, please share them in your comment!

@github-actions github-actions bot added the Resolution: Stale Issue or pull request is inactivity and unfortunately it will be *closed* if there is no response label Dec 16, 2024
@jpgoelz
Copy link
Author

jpgoelz commented Dec 16, 2024

This is still the case in PrimeNG v18.

Component API-Docs
TreeTable https://primeng.org/treetable#api.treetable.events.TreeTableLazyLoadEvent
Table https://primeng.org/table/#api.table.events.TableLazyLoadEvent

@mertsincan mertsincan added Resolution: Help Wanted Issue or pull request requires extra help and feedback and removed Resolution: Stale Issue or pull request is inactivity and unfortunately it will be *closed* if there is no response Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Dec 25, 2024
@mertsincan mertsincan added this to the Future milestone Dec 25, 2024
@github-project-automation github-project-automation bot moved this to Review in PrimeNG Dec 25, 2024
@github-actions GitHub Actions
Copy link

Due to PrimeNG team's busy roadmap, this issue is available for anyone to work on. Make sure to reference this issue in your pull request. ✨ Thank you for your contribution! ✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Resolution: Help Wanted Issue or pull request requires extra help and feedback
Projects
PrimeNG
Status: Review
Milestone
Future
Development

No branches or pull requests
2 participants
@mertsincan @jpgoelz