Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clicking the path of the SVG filter icon also triggers a column sort event #13955

Closed
harrkyle opened this issue Oct 25, 2023 · 1 comment
Closed
Labels
Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible

Comments

@harrkyle
Copy link

harrkyle commented Oct 25, 2023

Clicking directly on the path of an SVG filter icon in a table column triggers a column sort event. This does not happen if you click on the icon outside the path. This is because the target of the click is no longer the svg element, but the path within it and the sort event handler does not properly reject the click event.

return this.isFilterElementIconOrButton(element) || this.isFilterElementIconOrButton(element?.parentElement?.parentElement);

@github-actions github-actions bot added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Oct 25, 2023
@harrkyle
Copy link
Author

This appears to have been fixed already. Closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible
Projects
None yet
Development

No branches or pull requests

1 participant