Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Galleria: Cannot read properties of undefined when tabbing through component #13945

Closed
cmg-cchandler opened this issue Oct 23, 2023 · 0 comments · Fixed by #13947
Closed

Galleria: Cannot read properties of undefined when tabbing through component #13945

cmg-cchandler opened this issue Oct 23, 2023 · 0 comments · Fixed by #13947
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@cmg-cchandler
Copy link

Describe the bug

When tabbing through a galleria component, the tabbing will cause an unhandled exception stating Cannot read properties of undefined (reading: 'code') which is occurring within the onIndicatorKeyDown method of the GalleriaItem. This issue causes the tabbing to get stuck within the galleria item, and not progress to the next item on the page.

Proposed Fix:

(keydown)="onIndicatorKeyDown(event, index)"

The line above should be changed to $event instead of event so that the event object passed to the onIndicatorKeyDown method isn't undefined

image

Environment

PrimeNG 16.5.1 and Angular 16.0.5

Reproducer

No response

Angular version

16.0.5

PrimeNG version

16.5.1

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

18.14.0

Browser(s)

Chrome 118

Steps to reproduce the behavior

1.) On a page utilizing an existing p-galleria component with multiple images, tab into the component.
2.) Once you tab through all the navigator "dots" on the component, the error mentioned in the description will be shown in the console, and you'll be unable to tab out of the component.

Expected behavior

The console error shouldn't be thrown, and the user should be able to tab out of the p-galleria component.

@cmg-cchandler cmg-cchandler added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Oct 23, 2023
@cetincakiroglu cetincakiroglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Oct 25, 2023
@cetincakiroglu cetincakiroglu added this to the 16.5.2 milestone Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants