Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chart: canvasProps has no effect #13943

Closed
bmayen opened this issue Oct 23, 2023 · 4 comments
Closed

Chart: canvasProps has no effect #13943

bmayen opened this issue Oct 23, 2023 · 4 comments
Labels
Component: Documentation Issue or pull request is related to Documentation
Milestone

Comments

@bmayen
Copy link

bmayen commented Oct 23, 2023

Describe the bug

According to https://primeng.org/chart#accessibility, we should be able to supply canvasProps. However, doing so does not have any effect on the generated canvas element.

Environment

PrimeNG ^16

Reproducer

No response

Angular version

^16

PrimeNG version

^16

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

18

Browser(s)

No response

Steps to reproduce the behavior

<p-chart type="pie" [data]="data" [canvasProps]="{'role': 'img', 'aria-label': 'Data'}">

Expected behavior

Generated canvas element should have canvasProps assigned

@bmayen bmayen added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Oct 23, 2023
Copy link

This issue has been automatically marked as stale due to a lack of activity. If this issue is still relevant to you, please leave a comment so we can keep it open. We apologize for not being able to prioritize it sooner. If you have any new information or questions, please share them in your comment!

@github-actions github-actions bot added the Resolution: Stale Issue or pull request is inactivity and unfortunately it will be *closed* if there is no response label Dec 16, 2024
@bmayen
Copy link
Author

bmayen commented Dec 16, 2024

"If this issue is still relevant to you, please leave a comment"
Still relevant as this has not been addressed as far as I know.

@mertsincan
Copy link
Member

Thanks a lot for your update! Which PrimeNG version are you using? Could you please update issue template?

@mertsincan mertsincan added Status: Pending Review Issue or pull request is being reviewed by Core Team and removed Resolution: Stale Issue or pull request is inactivity and unfortunately it will be *closed* if there is no response Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Dec 16, 2024
@mertsincan mertsincan added this to the 18.0.1 milestone Dec 16, 2024
@github-project-automation github-project-automation bot moved this to Review in PrimeNG Dec 16, 2024
@mertsincan mertsincan added Component: Documentation Issue or pull request is related to Documentation and removed Status: Pending Review Issue or pull request is being reviewed by Core Team labels Dec 17, 2024
@mertsincan
Copy link
Member

Sorry but, this is a doc issue. in PrimeNG v20, we plan to add pt structure like in https://primevue.org/passthrough/

@github-project-automation github-project-automation bot moved this from Review to Done in PrimeNG Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Documentation Issue or pull request is related to Documentation
Projects
Status: Done
Development

No branches or pull requests

2 participants