Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Component: pAnimate should make pTable rows animate in/out of the viewport/DOM. #13918

Closed
BenRacicot opened this issue Oct 18, 2023 · 1 comment
Labels
Status: Discussion Issue or pull request needs to be discussed by Core Team Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible Type: New Feature Issue contains a new feature or new component request

Comments

@BenRacicot
Copy link

BenRacicot commented Oct 18, 2023

Describe the feature you would like to see added

pAnimate should make pTable rows animate in/out of the viewport/DOM.

Is your feature request related to a problem?

Yes, pAnimate docs are not clear on which elements it will work with.
pTable does not have any docs on animating its elements.

Describe the solution you'd like

pAnimate should just work as described on Prime components. Especially in situations like pTable where rows are dynamically set with a pTemplate.

<tr pAnimate leaveClass="flip">

Describe alternatives you have considered

I've tried Prime's pAnimate and searched for examples on using Angular's own animation but none exist.

@BenRacicot BenRacicot added Status: Discussion Issue or pull request needs to be discussed by Core Team Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible Type: New Feature Issue contains a new feature or new component request labels Oct 18, 2023
@BenRacicot BenRacicot changed the title Component: Title Component: pAnimate should make pTable rows animate in/out of the viewport/DOM. Oct 18, 2023
@cetincakiroglu
Copy link
Contributor

Hi,

pAnimate is deprecated and we've introduced pAnimateOnScroll. You cannot animate the table's row and it's not feasible. We do not have plans in our roadmap to implement such a feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Discussion Issue or pull request needs to be discussed by Core Team Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible Type: New Feature Issue contains a new feature or new component request
Projects
None yet
Development

No branches or pull requests

2 participants