Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pTooltip: Accidental console log left in production code #13892

Closed
jpgoelz opened this issue Oct 16, 2023 · 2 comments
Closed

pTooltip: Accidental console log left in production code #13892

jpgoelz opened this issue Oct 16, 2023 · 2 comments
Labels
Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible

Comments

@jpgoelz
Copy link

jpgoelz commented Oct 16, 2023 •
edited
Loading

Describe the bug

PR #13849 introduced an accidentally leftover console.log in line 268 of src/app/components/tooltip/tooltip.ts that prints e every time the id input is changed.

Environment

Any environment running PrimeNG 16.5.0.

Reproducer

No response

Angular version

16.2.9

PrimeNG version

16.5.0

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

18

Browser(s)

No response

Steps to reproduce the behavior

Add a [pTooltip] and an [id] property to any HTML tag and check the console.

Expected behavior

No response
@jpgoelz jpgoelz added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Oct 16, 2023
@jpgoelz
Copy link
Author

jpgoelz commented Oct 16, 2023

I will provide a PR for this.

@jpgoelz
Copy link
Author

jpgoelz commented Oct 16, 2023

Already gone.

@jpgoelz jpgoelz closed this as completed Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jpgoelz