Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dialog: bad drag behavior when keepInViewport is false #13856

Closed
aleprex99 opened this issue Oct 11, 2023 · 0 comments · Fixed by #13864
Closed

Dialog: bad drag behavior when keepInViewport is false #13856

aleprex99 opened this issue Oct 11, 2023 · 0 comments · Fixed by #13864
Labels
LTS-PORTABLE Issue's fix will be ported to supported LTS versions Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone
16.7.2

Comments

@aleprex99
Copy link
Contributor

Describe the bug

When the keepInViewport property of the p-dialog component is set to false dragging does not work properly.

p-dialog_keepInViewport_false_bug.mp4

Environment

Dev env on local and Prod env on a server

Reproducer

https://stackblitz.com/edit/github-pfuanq-uzulmh?file=src%2Fapp%2Fapp.component.html

Angular version

16.2.8

PrimeNG version

16.4.1

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

18.18.0

Browser(s)

No response

Steps to reproduce the behavior

  1. Use the Dialog component with [keepInViewport]="false"
  2. Open the Dialog
  3. Drag the Dialog

Expected behavior

No response
@aleprex99 aleprex99 added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Oct 11, 2023
aleprex99 added a commit to aleprex99/primeng that referenced this issue Oct 12, 2023
@aleprex99
Issue primefaces#13856 / Dialog: bad drag behavior when keepInViewpor…
7f8b13d 
…t is false

Fixes primefaces#13856
@aleprex99 aleprex99 mentioned this issue Oct 12, 2023
Merged
@cetincakiroglu cetincakiroglu added this to the 16.8.0 milestone Nov 8, 2023
@cetincakiroglu cetincakiroglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working LTS-PORTABLE Issue's fix will be ported to supported LTS versions and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Nov 8, 2023
cetincakiroglu added a commit that referenced this issue Nov 8, 2023
@cetincakiroglu
Merge pull request #13864 from aleprex99/master
993f999 
Issue #13856 / Dialog: bad drag behavior when keepInViewport is false
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
LTS-PORTABLE Issue's fix will be ported to supported LTS versions Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Milestone
16.7.2
Development

Successfully merging a pull request may close this issue.

Issue #13856 / Dialog: bad drag behavior when keepInViewport is false aleprex99/primeng
2 participants
@aleprex99 @cetincakiroglu